123580 - [FIX]about: protocol directory needs clean up

Status: CLOSED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Alexey Chernyak]

According to bug 68086, the following files should be removed from
mozilla/netwerk/protocol/about/src/

mzAboutMozilla.cpp
mzAboutMozilla.h
nsAboutCredits.cpp
nsAboutCredits.h
nsAboutPlugins.cpp
nsAboutPlugins.h

Some of these files are still referenced by nsAboutProtocolModule.cpp
However I could not find references to this file itself, so maybe it should be
removed as well, I'm not sure.

Comment 1

[Alexey Chernyak]

CCing some people from bug 68086

Comment 2

[Boris Zbarsky [:bzbarsky]]

Zach, would you be willing to make the mac build changes necessary for this, if
any?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch removing the dead files.

Tested on Linux, I've asked Zach to test on Mac.

Comment 4

[Zach Lipton [:zach]]

Tested on mac, all is ok

Comment 5

[Boris Zbarsky [:bzbarsky]]

leaf?  The patch builds on Linux/Mac.  Visual inspection shows the files are not
referenced no Win.  Would you review?

Comment 6

[Daniel (Leaf) Nunes]

Comment on attachment 68086 [details] [diff] [review]
Patch removing the dead files.

looks good, verified that about: urls still work without these files :)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

a=roc+moz for 0.9.9

Comment 8

[Boris Zbarsky [:bzbarsky]]

Files removed on trunk (pre-branch, so this made 0.9.9 :) ).

Comment 9

[Alexey Chernyak]

CLOSED