1235807 - Avoid querying bookmark state on every location change

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[:Margaret Leibovic]

Avoiding excessive DB queries could help reduce the frequency of bug 760394.

Comment 1

[:Margaret Leibovic]

Unfortunately, we probably need to always do this for large tablets, since the bookmark star is visible in the toolbar :/

At least if we remove the reading list icon from the menu, we won't need to do an additional query for the reading list state.

Comment 2

[Richard Newman [:rnewman]]

Put a write-through cache in the ContentProvider (will still use a Cursor interface, but won't allocate or hit the DB) or in LocalBrowserDB (requires invalidation on each sync).

Comment 3

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #2)
> Put a write-through cache in the ContentProvider (will still use a Cursor
> interface, but won't allocate or hit the DB) or in LocalBrowserDB (requires
> invalidation on each sync).

How do I do that?

Comment 4

[Richard Newman [:rnewman]]

Probably a ConcurrentHashMap or a Bloom filter keyed on URL. Write into it on a cache miss.

There are some overlaps with Bug 1197866…

Comment 5

[:Margaret Leibovic]

I'm not working on this. Maybe this would change with some of ahunt's upcoming bookmark work, but I don't think it's a high priority.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.