Closed Bug 1235881 Opened 4 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_video_test.js | Video Confirm video playback

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S6 - 1/29

People

(Reporter: mikehenrty, Assigned: tilman)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe][MJS])

Attachments

(4 files)

TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_video_test.js | Video Confirm video playback
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.VideoPlayer.tapMute (apps/system/test/marionette/lib/video_player.js:115:17)
    at Context.<anonymous> (apps/system/test/marionette/browser_video_test.js:61:12)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)

https://treeherder.mozilla.org/logviewer.html#?job_id=3248523&repo=gaia
Tilman, can you see why this is failing so often on automation?
Assignee: nobody → tilmankamp
Status: NEW → ASSIGNED
Attachment #8706256 - Flags: review?(mhenretty)
Comment on attachment 8706256 [details] [review]
[gaia] tilmankamp:fix-1235881 > mozilla-b2g:master

Great! I'm forwarding this along to Alberto since he originally converted this test from the python tests.
Attachment #8706256 - Flags: review?(mhenretty) → review?(apastor)
Comment on attachment 8706256 [details] [review]
[gaia] tilmankamp:fix-1235881 > mozilla-b2g:master

I followed the same approach originally, but I had some issues when taping on the fullscreen control. I don't remember exactly what was exactly the issue, and the code makes more sense to me now, so r+! Thanks!
Attachment #8706256 - Flags: review?(apastor) → review+
Merged into master:
https://github.com/tilmankamp/gaia/commit/071c78b53875aa5f577359b0b734fa9e7808a86e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Nope, still happening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8707941 - Flags: review?(mhenretty)
Attachment #8707941 - Flags: review?(apastor)
Hey! Left a couple of comments in GH
Flags: needinfo?(tilman)
(In reply to Alberto Pastor [:albertopq] from comment #15)
> Hey! Left a couple of comments in GH

You can find my answers there.
Flags: needinfo?(tilman)
Comment on attachment 8707941 [details] [review]
[gaia] tilmankamp:u1235881 > mozilla-b2g:master

Worth a try :)
Attachment #8707941 - Flags: review?(mhenretty) → review+
Attached video red.mov
The attached video illustrates some unexpected behavior (please look at it slowly/frame by frame). After the second "tapFullscreen..." in the terminal, the control panel should disappear and the browser should leave full-screen mode and show some chrome. The actual result in this case: The control panel disappears, reappears again and no chrome is coming up. Probability of this effect is somewhere around 1/30.
The last comment is related to the state before 
[gaia] tilmankamp:u1235881 > mozilla-b2g:master
(In reply to Tilman Kamp [:tilman] from comment #18)
> Created attachment 8708315 [details]
> red.mov
> 
> The attached video illustrates some unexpected behavior (please look at it
> slowly/frame by frame). After the second "tapFullscreen..." in the terminal,
> the control panel should disappear and the browser should leave full-screen
> mode and show some chrome. The actual result in this case: The control panel
> disappears, reappears again and no chrome is coming up. Probability of this
> effect is somewhere around 1/30.

Just thinking out loud, could the click on the fullscreen permission dialog be causing this? Not sure how to check it, so let's just merge it if the probability is so low
Attachment #8707941 - Flags: review?(apastor) → review+
Comment on attachment 8707941 [details] [review]
[gaia] tilmankamp:u1235881 > mozilla-b2g:master

Merged into master
https://github.com/tilmankamp/gaia/commit/f4593e03da5dcabcd630929438104fd6ebb41a31
I leave it on REOPENED for now. Let's see if it solved the problem.
No orange yet.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S6 - 1/29
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.