Do not approve suggestions automatically

RESOLVED FIXED

Status

Webtools
Pontoon
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gion, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(firefox46 affected)

Details

(Reporter)

Description

2 years ago
If a string has two unapproved suggestions and one of them is deleted, the other one is automatically approved. 

This happens quite often, when making suggestions and having to delete a suggestion containing an error. 

I think Pontoon should not automatically approve any suggestions if a user is in suggestion-mode.
Priority: -- → P2

Comment 1

2 years ago
Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/e71472d5f2b089fdcf68138d9e49bdbdd6221916
Fix bug 1235893: Don't approve suggestions on delete

Do not automatically approve next translation when deleting the active
one. Not just when in suggest mode like the bug description suggests,
but in general.

Automatic approval is dangerous and from now on we require localizers
to explicitly approve one of the remaining suggestions. To avoid any
surprises.

https://github.com/mozilla/pontoon/commit/c18ac77056fc98d2757776a78be95d195f6b8fd0
Merge pull request #327 from mathjazz/bug-1235893-do-not-approve-automatically

Fix bug 1235893: Don't approve suggestions on delete

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.