Closed Bug 1235965 Opened 5 years ago Closed 5 years ago

crash in PLDHashTable::Remove called from mozilla::a11y::AccessibleWrap::Shutdown()

Categories

(Core :: Disability Access APIs, defect)

Unspecified
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: dbaron, Assigned: tbsaunde)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-b5efbc58-401d-4216-b79f-6e4642151229.
=============================================================

Though it's not enough to be called a topcrash, it's probably worth noting that the bulk of the crashes in nightly in  PLDHashTable::Remove are now crashes where it is called from mozilla::a11y::AccessibleWrap::Shutdown().

https://crash-stats.mozilla.com/signature/?product=Firefox&release_channel=nightly&signature=PLDHashTable%3A%3ARemove is a query for crashes in the past week (always current, not the past week from when I'm filing).  Hopefully bug 1229238 will improve the stack signature soon, though.
so I'm pretty sure mDoc is null when AccessibleWrap::Shutdown() is called which I don't think should ever happen.  I'm worried that ignoring this will leave garbage in the document's hash table mapping ids to objects, but I don't really see another option than just not trying to remove the object from the hash table if mDoc is null.
Comment on attachment 8704778 [details] [diff] [review]
null check mDoc in AccessibleWrap::Shutdown()

Review of attachment 8704778 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have a better idea.
Attachment #8704778 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/22557c6ebe30
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.