1235979 - 3d transforms trigger many lines of terminal-spam like "depth 0x7fb2783f9d30 0.000000"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start Firefox (opt or debug, doesn't matter) from the terminal.
 2. Visit vulturiceye.com
 3. Hover some piece of the page, and watch your terminal.

ACTUAL RESULTS:
Many lines like the following:
depth 0x7fb2834e4020 0.000000
depth 0x7fb283428530 0.000000
depth 0x7fb2834e5020 0.000000
depth 0x7fb283428530 0.000000
depth 0x7fb2834e5020 0.000000
depth 0x7fb283428530 0.000000
depth 0x7fb2834e5020 0.000000

EXPECTED RESULTS:
No such terminal-spam.

I'm pretty sure this is coming from this line, added in bug 1226904's patch:
> 1959           printf("depth %p %f\n", transform, transform->GetHitDepthAtPoint(aBuilder, point));
http://hg.mozilla.org/mozilla-central/rev/f950b7a04741#l1.91

Thinker, do we need this line, or can we get rid of it? (I'm guessing it was just some debug logging that got left in by accident?)

Comment 1

[Thinker Li [:sinker]]

Right!  I would remove it.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Landing the one-liner with rs=thinker. Calling Fx45 affected since bug 1226904 is almost certain to be uplifted there at some point as well.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3866546b914

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d3866546b914

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I was going to uplift this to aurora, but it looks like the patch for bug 1226904 that got uplifted to aurora didn't include the printf line to begin with.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This along with the change that caused this regression were backed out from Firefox 45.

https://hg.mozilla.org/releases/mozilla-aurora/rev/64ec448f156d