1236029 - Intermittent TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_context_menu_test.js | Browser Context Menu share url

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] failure state

12:50:23     INFO -  TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_context_menu_test.js | Browser Context Menu share url
12:50:23     INFO -  Error: timeout exceeded!
12:50:23     INFO -      at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
12:50:23     INFO -      at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
12:50:23     INFO -      at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:143:12)
12:50:23     INFO -      at Object.appChromeContextLink (apps/system/test/marionette/lib/system.js:168:31)
12:50:23     INFO -      at Object.System.shareLink (apps/system/test/marionette/lib/system.js:385:9)
12:50:23     INFO -      at Context.<anonymous> (apps/system/test/marionette/browser_context_menu_test.js:40:12)
12:50:23     INFO -      at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
12:50:23     INFO -      at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
12:50:23     INFO -      at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)

https://treeherder.mozilla.org/logviewer.html#?job_id=3652649&repo=b2g-inbound

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Judging from the screenshot, when we block banned ports we don't show the browser context menu button. Since we are only hitting localhost, let's relax these restrictions.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8703132 [details] [review]
[gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

Aus or Gareth, can you have a look?

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8703132 [details] [review]
[gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

LGTM after brief discussion with :mhenretty on irc. Basically the thing that serves web pages to test things like search starts on a random port and we're turning off security pref (only for Gij) to block traffic on certain ports.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/4a45b3a060a9844531d06c8033066ed3f1dddefd

Comment 6

[Aus Lacroix [:aus]]

Comment on attachment 8703132 [details] [review]
[gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

:gaye took care of the review. :) I did look at it post-commit and it looked good to me as well. Nice find there. =)

Comment 7

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* fx-team: 2

Platform breakdown:
* mulet-linux64: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1236029&startday=2016-01-18&endday=2016-01-24&tree=all