Closed Bug 1236029 Opened 4 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_context_menu_test.js | Browser Context Menu share url

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: mikehenrty, Assigned: mikehenrty)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe][MJS])

Attachments

(2 files)

12:50:23     INFO -  TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_context_menu_test.js | Browser Context Menu share url
12:50:23     INFO -  Error: timeout exceeded!
12:50:23     INFO -      at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
12:50:23     INFO -      at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
12:50:23     INFO -      at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:143:12)
12:50:23     INFO -      at Object.appChromeContextLink (apps/system/test/marionette/lib/system.js:168:31)
12:50:23     INFO -      at Object.System.shareLink (apps/system/test/marionette/lib/system.js:385:9)
12:50:23     INFO -      at Context.<anonymous> (apps/system/test/marionette/browser_context_menu_test.js:40:12)
12:50:23     INFO -      at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
12:50:23     INFO -      at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
12:50:23     INFO -      at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)

https://treeherder.mozilla.org/logviewer.html#?job_id=3652649&repo=b2g-inbound
Judging from the screenshot, when we block banned ports we don't show the browser context menu button. Since we are only hitting localhost, let's relax these restrictions.
No longer blocks: 1236038
Comment on attachment 8703132 [details] [review]
[gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

Aus or Gareth, can you have a look?
Attachment #8703132 - Flags: review?(gaye)
Attachment #8703132 - Flags: review?(aus)
Comment on attachment 8703132 [details] [review]
[gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

LGTM after brief discussion with :mhenretty on irc. Basically the thing that serves web pages to test things like search starts on a random port and we're turning off security pref (only for Gij) to block traffic on certain ports.
Attachment #8703132 - Flags: review?(gaye) → review+
master: https://github.com/mozilla-b2g/gaia/commit/4a45b3a060a9844531d06c8033066ed3f1dddefd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8703132 [details] [review]
[gaia] mikehenrty:bug-1236029-banned-ports-override > mozilla-b2g:master

:gaye took care of the review. :) I did look at it post-commit and it looked good to me as well. Nice find there. =)
Attachment #8703132 - Flags: review?(aus)
Target Milestone: --- → 2.6 S5 - 1/15
You need to log in before you can comment on or make changes to this bug.