Closed Bug 1236049 Opened 5 years ago Closed 5 years ago
crash in android
.util .Android Runtime Exception: Calling start Activity() from outside of an Activity context requires the FLAG _ACTIVITY _NEW _TASK flag . Is this really what you want? at android .app .Context Impl .start Activity(Context Impl .java)
+++ This bug was initially created as a clone of Bug #1224295 +++ Missed a spot in the fix for bug 1224295.
Use an Activity as the Context when we have one. This avoids the crash and also avoids an ugly black flash when you cancel the intent chooser. When we don't have an activity, use an application context and add the new task flag.
Attachment #8703172 - Flags: review?(s.kaspari)
Attachment #8703172 - Flags: review?(s.kaspari) → review+
Jim, this is present in 45, please uplift.
Comment on attachment 8703172 [details] [diff] [review] Be smarter about which Context to use for opening Intent (v1) Approval Request Comment [Feature/regressing bug #]: Bug 1219016 [User impact if declined]: Possible crash when opening external URL. [Describe test coverage new/current, TreeHerder]: Locally, m-c, aurora [Risks and why]: Very small; patch has been on m-c for a while. [String/UUID change made/needed]: None
Attachment #8703172 - Flags: approval-mozilla-beta?
Comment on attachment 8703172 [details] [diff] [review] Be smarter about which Context to use for opening Intent (v1) Fix a crash, taking it. Should be in 45 beta 2.
Attachment #8703172 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.