1236049 - crash in android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? at android.app.ContextImpl.startActivity(ContextImpl.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

+++ This bug was initially created as a clone of Bug #1224295 +++

Missed a spot in the fix for bug 1224295.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Be smarter about which Context to use for opening Intent (v1)

Use an Activity as the Context when we have one. This avoids the crash
and also avoids an ugly black flash when you cancel the intent chooser.
When we don't have an activity, use an application context and add the
new task flag.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0e7d1e3945e

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0e7d1e3945e

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim, this is present in 45, please uplift.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8703172 [details] [diff] [review]
Be smarter about which Context to use for opening Intent (v1)

Approval Request Comment
[Feature/regressing bug #]: Bug 1219016
[User impact if declined]: Possible crash when opening external URL.
[Describe test coverage new/current, TreeHerder]: Locally, m-c, aurora
[Risks and why]: Very small; patch has been on m-c for a while.
[String/UUID change made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8703172 [details] [diff] [review]
Be smarter about which Context to use for opening Intent (v1)

Fix a crash, taking it.
Should be in 45 beta 2.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bcdcf7bb2b96