123605 - Use correct twisty size everywhere, not just only in PaintTwisty()

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Jan Varga [:janv]]

"GetFinalImageSize() to get the dimensions of the twisty will be wrong when the
skin is using a theme impl. You have to query the theme impl to get the
width/height of the twisty."

So, we can add a new method, e.g. GetTwistySize() and use that for twisty size.
w/o margins

Comment 1

[Neil Deakin]

Attachment: Use native theme for calculating twisty width

Comment 2

[[e-mail]]

Comment on attachment 224357 [details] [diff] [review]
Use native theme for calculating twisty width

>+  aImageRect = GetImageSize(aRowIndex, aColumn, PR_TRUE, aTwistyContext);
>+  if (aImageRect.height > aTwistyRect.height)
>+    aImageRect.height = aTwistyRect.height;
>+  if (aImageRect.width > aTwistyRect.width)
>+    aImageRect.width = aTwistyRect.width;
>+  else
>+    aTwistyRect.width = aImageRect.width;
I think the code would be clearer if this part was at the start, before the theme code, followed by the nsITheme tests. I also think that GetTwistyRect should return the nsITheme pointer as that value only has one consumer, e.g.
  PRUint8 appearance = aTwistyContext->GetStyleDisplay()->mAppearance;
  if (!appearance)
    return nsnull;

  nsITheme *theme = aPresContext->GetTheme();
  if (!theme || !theme->ThemeSupportsWidget(aPresContext, nsnull, appearance))
    return nsnull;
/* ... */
  return theme;

>+    if (aTwistyRect.width < minTwistySize.width || !canOverride)
>+      aTwistyRect.width = minTwistySize.width;
Odd. I wonder what happens to the height.

Comment 3

[Jan Varga [:janv]]

Yeah, I also wonder why we need the aImageRect output argument. Otherwise, it looks correct.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 224357 [details] [diff] [review]
Use native theme for calculating twisty width

r=varga with Neil's comments addressed and removed aImageRect (if possible)

Comment 5

[Neil Deakin]

checked in, but I didn't remove the image size, since it may not be the same as the twisty area.