Fix comment in DebuggerClient.prototype.connect

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: linclark, Assigned: linclark)

Tracking

Trunk
Firefox 46

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The comment talks about DebuggerServer, but the code is using DebuggerClient. I think the comment was a typo, but will ask the original author to confirm.
(Assignee)

Comment 1

3 years ago
Created attachment 8703162 [details] [diff] [review]
Bug1236052.patch

Honza, can you confirm whether this comment should say DebuggerClient?
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Attachment #8703162 - Flags: review?(odvarko)
Comment on attachment 8703162 [details] [diff] [review]
Bug1236052.patch

Review of attachment 8703162 [details] [diff] [review]:
-----------------------------------------------------------------

You are right the comment is now fixed, thanks!
Honza
Attachment #8703162 - Flags: review?(odvarko) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4ef357c91657
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46

Comment 5

3 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.