1236060 - Utterance errors don't advance queue

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Eitan Isaacson [:eeejay]]

If an utterance ends with an error, the window and global queue don't advance.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Dispatch error should advance queue.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8703170 [details] [diff] [review]
Dispatch error should advance queue.

> nsSpeechTask::DispatchError(float aElapsedTime, uint32_t aCharIndex)
> {
>+  LOG(LogLevel::Debug, ("nsSpeechTask::DispatchError"));
>+
>   if (!mIndirectAudio) {
>     NS_WARNING("Can't call DispatchError() from a direct audio speech service");
>     return NS_ERROR_FAILURE;
>   }
> 
>+  if (!mPreCanceled) {
>+    nsSynthVoiceRegistry::GetInstance()->SpeakNext();
>+  }
>+
>   return DispatchErrorImpl(aElapsedTime, aCharIndex);
> }
> 
> nsresult
> nsSpeechTask::DispatchErrorImpl(float aElapsedTime, uint32_t aCharIndex)
> {
>   MOZ_ASSERT(mUtterance);
>   if(NS_WARN_IF(mUtterance->mState == SpeechSynthesisUtterance::STATE_ENDED)) {
>     return NS_ERROR_NOT_AVAILABLE;
>   }
> 
>+  if (mSpeechSynthesis) {
>+    mSpeechSynthesis->OnEnd(this);
>+  }
>+
>   mUtterance->mState = SpeechSynthesisUtterance::STATE_ENDED;
>   mUtterance->DispatchSpeechSynthesisEvent(NS_LITERAL_STRING("error"),
>                                            aCharIndex, aElapsedTime,
>                                            EmptyString());

This looks a bit odd. We call SpeakNext before dispatching error event. I'd expect error event handler to be able to cancel proceeding altogether.
Also calling SpeakNext() before calling OnEnd(), is that really what happens in non-error cases?
Could you explain or fix, and ask review again.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8703170 [details] [diff] [review]
Dispatch error should advance queue.

oh, actually, perhaps we want this behavior so that error listener can cancel the already scheduled thing.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67ea3d1ffcdb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67ea3d1ffcdb