1236091 - Null check in BlitFramebuffer

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Null check in BlitFramebuffer

We trigger this during deqp/functional/gles3/framebufferblit.html

Comment 1

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8703200 [details] [diff] [review]
Null check in BlitFramebuffer

Review of attachment 8703200 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextFramebuffers.cpp
@@ +118,5 @@
>          return;
>      }
>  
> +    if (mBoundReadFramebuffer && !mBoundReadFramebuffer->ValidateAndInitAttachments("blitFramebuffer's READ_FRAMEBUFFER") ||
> +        mBoundDrawFramebuffer && !mBoundDrawFramebuffer->ValidateAndInitAttachments("blitFramebuffer's DRAW_FRAMEBUFFER"))

Should really just move these down into their respective branches below.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af2a9677e580

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af2a9677e580