Null check in BlitFramebuffer

RESOLVED FIXED in Firefox 46

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug)

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8703200 [details] [diff] [review]
Null check in BlitFramebuffer

We trigger this during deqp/functional/gles3/framebufferblit.html
(Assignee)

Updated

2 years ago
Attachment #8703200 - Attachment is patch: true
Attachment #8703200 - Attachment mime type: text/x-patch → text/plain
Attachment #8703200 - Flags: review?(jgilbert)
(Assignee)

Updated

2 years ago
Blocks: 889977
Comment on attachment 8703200 [details] [diff] [review]
Null check in BlitFramebuffer

Review of attachment 8703200 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextFramebuffers.cpp
@@ +118,5 @@
>          return;
>      }
>  
> +    if (mBoundReadFramebuffer && !mBoundReadFramebuffer->ValidateAndInitAttachments("blitFramebuffer's READ_FRAMEBUFFER") ||
> +        mBoundDrawFramebuffer && !mBoundDrawFramebuffer->ValidateAndInitAttachments("blitFramebuffer's DRAW_FRAMEBUFFER"))

Should really just move these down into their respective branches below.
Attachment #8703200 - Flags: review?(jgilbert) → review+

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/af2a9677e580
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee: nobody → jmuizelaar
You need to log in before you can comment on or make changes to this bug.