1236120 - FFMpeg PDM always assumes image has a (0,0) offset.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

The FFmpeg PDM always assumes the image offset is (0,0) ; this is fine with h264 decoder but not with webm.

This is what caused the reftest errors in bug 1214462 and caused the backout.

Creating a separated bug so it can be uplifted as this could affect all linux users playing youtube.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: [ffmpeg] Use demuxed dimensions to determine picture size and offset

Bug 1236120: [ffmpeg] Use demuxed dimensions to determine picture size and offset. r=gerald
    
Don't assume it always has an offset of (0,0)

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d4b1c817a4

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0d4b1c817a4

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8703240 [details] [diff] [review]
[ffmpeg] Use demuxed dimensions to determine picture size and offset

Approval Request Comment
[Feature/regressing bug #]: 1236120
[User impact if declined]: Invalid aspect ratio or wrong offset position
[Describe test coverage new/current, TreeHerder]: In central, manual testing
[Risks and why]: Low. This is the same logic also used on Windows and Mac
[String/UUID change made/needed]: None

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8703240 [details] [diff] [review]
[ffmpeg] Use demuxed dimensions to determine picture size and offset

This fixes reftests failure and has been in Nightly for a few days, Beta44+

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f7687a837b45

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e8b2e5c39d6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4e8b2e5c39d6