1236164 - Own searchBox styling should also be used in Contacts sidebar of compose window

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nomis101]

Bug 1211864 introduced our own searchBox styling for Thunderbird for most search boxes. But not for the contacts sidebar of the compose window. It should be used there as well (I think this should be abContactsPanel.xul).

Comment 1

[Richard Marti (:Paenglab)]

Attachment: sidebarSearch.patch

I somehow missed this. Probably because I thought it's used from addressbook.xul with the same ID (peopleSearchInput).

Comment 2

[aleth [:aleth]]

Comment on attachment 8703342 [details] [diff] [review]
sidebarSearch.patch

Review of attachment 8703342 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this got bitrotted? Or does it depend on something else?
patching file mail/themes/windows/mail/searchBox.css
Hunk #1 FAILED at 157

Comment 3

[Richard Marti (:Paenglab)]

Attachment: sidebarSearch.patch

Sorry I forgot to check the dependencies, it was bug 1234061. So we will see which bug can land first and rot the other one.

Comment 4

[aleth [:aleth]]

Comment on attachment 8704733 [details] [diff] [review]
sidebarSearch.patch

Review of attachment 8704733 [details] [diff] [review]:
-----------------------------------------------------------------

NB: Typo in the commit message.

Comment 5

[aleth [:aleth]]

Needs uplift, I guess

Comment 6

[Richard Marti (:Paenglab)]

Attachment: sidebarSearch.patch

Fixed the typo in commit message.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/d991c69647956679c1cafa15a2d7109cf0801627
Bug 1236164 - Add the searchBox class to the Contacts sidebar search. r=aleth

Comment 8

[Jorg K (CEST = GMT+2)]

Aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/98ebf79bc3ab

Comment 9

[Jorg K (CEST = GMT+2)]

For the record: There was a merge conflict in /mail/themes/windows/mail/searchBox.css with bug 1234061.
See comment #3 and bug 1234061 comment #10 and bug 1234061 comment #12 ("backported").
This should have landed on Aurora before bug 1234061 to save two people the hassle of fixing up patches manually.