123617 - OS X: Can't tab to buttons, checkboxes or radiobuttons in Classic (Aqua?) theme

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[scalkins]

Mac OSX 2002-02-04-08 Trunk
Putting this under browser themes cause I can only repro it in Classic/Aqua
theme on OSX

Steps to repro:
1)Launch NS 6 with a new profile
2) GO to setup Mail, or go to Edit Preferences, using only keyboard (Try tabbing
to radio buttons or buttons in right pane)

Actual results: You cannot tab to these items anywhere in Classic theme.

Comment 1

[scalkins]

This affects IM setup as well.

Comment 2

[Joe Hewitt (gone)]

buttons on MacOS do not receive focus.  In this case, they may actually have
focus, they just aren't displaying it because there is no visual style for
focused buttons in aqua

Comment 3

[sairuh (rarely reading bugmail)]

if you set your Keyboard system preference on OS X to be able to tab to any
widget, aqua buttons do display focus.

with that in mind, is this still unfixable for the "aqua" (classic) theme on OS
X? reopening for reconsideration. readjusting summary, too, since checkboxes and
radiobuttons are also affected.

see also bug 187508, to respect the OS X Keyboard sys pref.

Comment 4

[sairuh (rarely reading bugmail)]

-> over to shliang for now.

Comment 5

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 6

[shliang]

Attachment: patch

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 117977 [details] [diff] [review]
patch

>Index: content/events/src/nsEventStateManager.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v
>retrieving revision 1.422
>diff -u -w -r1.422 nsEventStateManager.cpp
>--- content/events/src/nsEventStateManager.cpp	8 Mar 2003 01:09:26 -0000	1.422
>+++ content/events/src/nsEventStateManager.cpp	21 Mar 2003 06:59:30 -0000
>@@ -3780,6 +3780,17 @@
>   if (aContent == mCurrentFocus) {
>     aState |= NS_EVENT_STATE_FOCUS;
>   }
>+  else if (aContent->IsContentOfType(nsIContent::eXUL)) {
>+    nsCOMPtr<nsIAtom> tag;
>+    aContent->GetTag(*getter_AddRefs(tag));
>+    if (tag == nsXULAtoms::radio) {
>+      nsCOMPtr<nsIAtom> focusedAtom = do_GetAtom("focused");
>+      nsAutoString focused;
>+      aContent->GetAttr(kNameSpaceID_None, focusedAtom, focused);
>+      if (focused == NS_LITERAL_STRING("true"))
>+        aState |= NS_EVENT_STATE_FOCUS;
>+    }
>+  }
>   if (aContent == mDragOverContent) {
>     aState |= NS_EVENT_STATE_DRAGOVER;
>   }

This isn't the right place to fix this.  gfx/src/mac/nsNativeThemeMac.cpp (or
perhaps gfx/src/shared/nsNativeTheme.cpp now) should be checking the focused
attribute instead of the event state already, for radio buttons.  Is there a
problem with the logic there that does this?

The rest of the changes look fine - we'll now just tab based on the
accessibility.tabfocus pref.

Comment 8

[sairuh (rarely reading bugmail)]

tabbing to chrome widgets should be independent of the accessibility.tabfocus pref.

Comment 9

[shliang]

Attachment: patch

Comment 10

[Brian Ryner (not reading)]

Comment on attachment 118160 [details] [diff] [review]
patch

I hate to nitpick, but could you move IsFocused into
gfx/src/shared/nsNativeTheme.cpp?   This is platform-independent code that will
be useful when all platforms share the common base class.

Comment 11

[shliang]

Attachment: patch

Comment 12

[shliang]

Comment on attachment 118340 [details] [diff] [review]
patch

i updated and had to change a couple things

Comment 13

[shliang]

Attachment: patch

ok, moving to GetContentState in shared/nsNativeTheme

Comment 14

[shliang]

resolving

Comment 15

[sairuh (rarely reading bugmail)]

i tested this with 2003.03.27.03 on mac os x 10.2.4, and this works nicely in
classic (regardless of accessibility.tabfocus).

thanks for fixing this!

Comment 16

[sairuh (rarely reading bugmail)]

actually, just found that selection lists (droplists) don't get focus, still.
rather than reopening this, i've filed another bug: bug 200160.