Closed Bug 1236229 Opened 5 years ago Closed 5 years ago
[experiment] The show
Info API in UITour .jsm should accept Java Script callbacks rather than callback IDs
58 bytes, text/x-review-board-request
Review commit: https://reviewboard.mozilla.org/r/29341/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29341/
Attachment #8703344 - Flags: review?(MattN+bmo)
Is this a breaking change to the current API? Please note that showInfo is already in use extensively on mozorg, so breaking changes should be avoided unless absolutely necessary. We also need to maintain compatibility for older versions of Firefox.
Just to be clear, I'm only asking in terms of the web content API that mozorg uses here, as opposed to anything internal in Firefox itself.
Attachment #8703344 - Flags: review?(MattN+bmo) → review+
Tryserver build with the argument removed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eee393cfb3f3
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in before you can comment on or make changes to this bug.