Unaccelerated OS X problems with history window and thunderbird

RESOLVED FIXED in Firefox 45

Status

()

Core
Graphics
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Pike, Assigned: mstange)

Tracking

({regression})

Trunk
mozilla46
Unspecified
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(firefox45 fixed, firefox46 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Reporter)

Description

2 years ago
Created attachment 8703377 [details]
Screen Shot 2016-01-03 at 00.24.22.png

20160102030203 doesn't render on osx for me.

Safe mode didn't help, the error console doesn't say anything useful.

The funny thing is that about:support renders fine, seems to be something with the three pane view?

Marking as blocker, as I can't use daily to read mail.

Screenshot attached. The non-rendering parts were initially all white, but grew those black lines as I resized the window.
On my Mountain Lion and Yosemite VMs today Daily is still working.

Axel, are you on El Capitan? Aleth reported today seeing also such problem.

Comment 2

2 years ago
pretty funky modern art you got there. Doesnot happen with Firefox nightly?

presumably a regression.
Keywords: regression, regressionwindow-wanted
Version: unspecified → Trunk
(Reporter)

Comment 3

2 years ago
Nightly 20160102030217 is fine. And I'm on El Capitan, yes.

My previous build ID was 20151230030209, looking at my update logs

My about:support data, including graphics card details:

  Application Basics

    Name: Thunderbird
    Version: 46.0a1
    User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Thunderbird/46.0a1
    Profile Folder: Show in Finder
    Application Build ID: 20160102030203
    Enabled Plugins: about:plugins
    Build Configuration: about:buildconfig
    Memory Use: about:memory
    Profiles: about:profiles

  Mail and News Accounts
    account1:
      INCOMING: account1, , (imap) imap.googlemail.com:993, SSL, passwordCleartext
      OUTGOING: , smtp.googlemail.com:465, SSL, passwordCleartext, true
      OUTGOING: , smtp.googlemail.com:465, SSL, passwordCleartext, false
      OUTGOING: , smtp.googlemail.com:465, SSL, passwordCleartext, false
      OUTGOING: , smtp.googlemail.com:465, SSL, passwordCleartext, false
      OUTGOING: , smtp.googlemail.com:465, SSL, passwordCleartext, false

    account2:
      INCOMING: account2, , (none) Local Folders, plain, passwordCleartext

    account3:
      INCOMING: account3, , (nntp) news.mozilla.org:119, plain, passwordCleartext
      OUTGOING: , smtp.googlemail.com:465, SSL, passwordCleartext, true

  Crash Reports

  Extensions
    Lightning, 4.8a1, false, {e2fda1a4-762b-4020-b5ad-a41df1933103}

  Important Modified Preferences

    Name: Value

      browser.cache.disk.capacity: 358400
      browser.cache.disk.filesystem_reported: 1
      browser.cache.disk.smart_size_cached_value: 358400
      browser.cache.disk.smart_size.first_run: false
      browser.cache.disk.smart_size.use_old_max: false
      extensions.lastAppVersion: 46.0a1
      gfx.blacklist.direct2d: 3
      mail.openMessageBehavior.version: 1
      mail.spotlight.firstRunDone: true
      mailnews.database.global.datastore.id: 1e8f5443-4ac9-c044-83f2-22ecc3df790
      network.cookie.prefsMigrated: true
      network.predictor.cleaned-up: true
      places.database.lastMaintenance: 1451316384
      places.history.expiration.transient_current_max_pages: 104858
      plugin.importedState: true

  Graphics

      Vendor ID: 0x8086
      Device ID: 0x0d26
      WebGL Renderer: ATI Technologies Inc. -- AMD Radeon R9 M370X OpenGL Engine -- 2.1 ATI-1.40.15
      GPU Accelerated Windows: 0

      AzureCanvasBackend: skia
      AzureSkiaAccelerated: 1
      AzureFallbackCanvasBackend: none
      AzureContentBackend: quartz

  JavaScript

  Incremental GC: 1

  Accessibility

    Activated: 0
    Prevent Accessibility: 0

  Library Versions

      Expected minimum version
      Version in use

      NSPR
      4.11
      4.11

      NSS
      3.21 Basic ECC
      3.21 Basic ECC

      NSS Util
      3.21
      3.21

      NSS SSL
      3.21 Basic ECC
      3.21 Basic ECC

      NSS S/MIME
      3.21 Basic ECC
      3.21 Basic ECC

Comment 4

2 years ago
m-c Regression window: 22f51211915b to e6ba2d4a2e49

Likely something needs porting.

Calendar tabs seem to be OK.

Updated

2 years ago
Summary: Daily 20160102030203 renders unusable → Daily 20160102030203 renders unusable on OS X 10.11
(Reporter)

Comment 5

2 years ago
bug 1082598 updated skia?

CC lsalzmann, who's the owner of that bug.

Updated

2 years ago
Keywords: regressionwindow-wanted
Whiteboard: [gfx-noted]
(Assignee)

Comment 6

2 years ago
Is bug 1187322 in the regression range?

Comment 8

2 years ago
I have this too, on El Capitan.

Last OK build was Daily 1229; Daily 1230 shows the problem (for me), as does today's 20160104.
Created attachment 8703820 [details]
Screen Shot 2016-01-04 at 16.34.17 .png

Earlybird download link is busted (https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-earlybird/thunderbird-43.0a2.en-US.mac.dmg from this page: https://www.mozilla.org/en-US/thunderbird/channel/), but if I get the latest release, I can reproduce this locally on 10.11.2.  Not quite as above, lots of blank areas instead.
I'll try making a local build see what happens.  Haven't done thunderbird builds before :)
Are these of consequence?

[45701] WARNING: A control runnable was posted to a worker that is already shutting down!: file /Users/msreckovic/Repos/comm-central/mozilla/dom/workers/WorkerPrivate.cpp, line 2337
Enabling "hardware acceleration when available" makes the problem go away for me.
(Reporter)

Comment 13

2 years ago
(In reply to Milan Sreckovic [:milan] from comment #12)
> Enabling "hardware acceleration when available" makes the problem go away
> for me.

Just tested, I can confirm that it does for me, too.
So, comment 7 non-withstanding, bug 1187322 would be a really good candidate :)  I'll see if I take that out locally and test.

Comment 15

2 years ago
(In reply to Milan Sreckovic [:milan] from comment #12)
> Enabling "hardware acceleration when available" makes the problem go away
> for me.

ditto. thanks much indeed.

Comment 16

2 years ago
What about Firefox nightlies with hardware acceleration disabled?
(Reporter)

Comment 17

2 years ago
Created attachment 8704019 [details]
Firefox history window without hardware accel

Just tested, and found the same behaviour in the history window.
Benoit, can you take a look at reproducing Firefox problem from comment 17?
Flags: needinfo?(bgirard)
Never mind, I can reproduce,looking for a regression range in inbound, after this came up for the nightly builds: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9ddf0da90fb3bc1ae29966dc596013fc54a44bd2&tochange=c690c50b2b543b420803e8192d6e08e06b20e0a3
Flags: needinfo?(bgirard)
Inbound regression range got a bit confused over some temporary instabilities in that build, but I've done local builds and confirmed bug 1187322 causing the comment 17 workflow failure.
Assignee: nobody → mstange
Blocks: 1187322
Component: General → Graphics
Product: Thunderbird → Core
Summary: Daily 20160102030203 renders unusable on OS X 10.11 → Unaccelerated OS X problems with history window and t-bird

Updated

2 years ago
Duplicate of this bug: 1238071

Comment 22

2 years ago
Magnus, is bug 1238071 really a dupe of this one?

The visible behaviour is quite different, and bug 1238071 occurs with hardware accel enabled, which was the workaround for this bug, surely, and this synopsis mentioned unaccelerated problems?

Updated

2 years ago
Flags: needinfo?(mkmelin+mozilla)

Comment 23

2 years ago
Ah no, but should be bug 1237602.
Flags: needinfo?(mkmelin+mozilla)

Comment 24

2 years ago
thanks Magnus.
(Assignee)

Comment 25

2 years ago
Created attachment 8706620 [details]
MozReview Request: Bug 1236282 - Clip color layer drawing in BasicCompositor so that unbounded operators don't erase stuff outside the layer. r?bas.schouten

The same as bug 1077358, but for BasicCompositor.

Review commit: https://reviewboard.mozilla.org/r/30401/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30401/
Attachment #8706620 - Flags: review?(bas)
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1238539

Updated

2 years ago
Summary: Unaccelerated OS X problems with history window and t-bird → Unaccelerated OS X problems with history window and thunderbird
Comment on attachment 8706620 [details]
MozReview Request: Bug 1236282 - Clip color layer drawing in BasicCompositor so that unbounded operators don't erase stuff outside the layer. r?bas.schouten

https://reviewboard.mozilla.org/r/30401/#review27209

::: gfx/layers/basic/BasicCompositor.cpp:410
(Diff revision 1)
> +      dest->PushClipRect(aRect);

Could we call this conditionally? This is potentially expensive, especially when it's useless.
Attachment #8706620 - Flags: review?(bas) → review+
(Assignee)

Comment 29

2 years ago
(In reply to Bas Schouten (:bas.schouten) from comment #27)
> Comment on attachment 8706620 [details]
> MozReview Request: Bug 1236282 - Clip color layer drawing in BasicCompositor
> so that unbounded operators don't erase stuff outside the layer.
> r?bas.schouten
> 
> https://reviewboard.mozilla.org/r/30401/#review27209
> 
> ::: gfx/layers/basic/BasicCompositor.cpp:410
> (Diff revision 1)
> > +      dest->PushClipRect(aRect);
> 
> Could we call this conditionally? This is potentially expensive, especially
> when it's useless.

I made it conditional on !IsOperatorBoundByMask(blendMode).

Comment 30

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2d9ac4e9f6bc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
(Assignee)

Comment 31

2 years ago
Comment on attachment 8706620 [details]
MozReview Request: Bug 1236282 - Clip color layer drawing in BasicCompositor so that unbounded operators don't erase stuff outside the layer. r?bas.schouten

Approval Request Comment
[Feature/regressing bug #]: BasicCompositor on OS X
[User impact if declined]: blank windows when the sidebar opens for users without hardware acceleration
[Describe test coverage new/current, TreeHerder]: none (we don't run any tests with hardware acceleration disabled on OS X)
[Risks and why]: very low, simple patch that has baked on trunk for almost two weeks
[String/UUID change made/needed]: none
Attachment #8706620 - Flags: approval-mozilla-aurora?
Comment on attachment 8706620 [details]
MozReview Request: Bug 1236282 - Clip color layer drawing in BasicCompositor so that unbounded operators don't erase stuff outside the layer. r?bas.schouten

Switching the uplift request to beta as it's for 45.
Attachment #8706620 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
status-firefox45: --- → affected
Comment on attachment 8706620 [details]
MozReview Request: Bug 1236282 - Clip color layer drawing in BasicCompositor so that unbounded operators don't erase stuff outside the layer. r?bas.schouten

Fix an important graphic issue, taking it.

Should be in 45 beta 2.
Attachment #8706620 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 34

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b4a6b584ecb2
status-firefox45: affected → fixed
You need to log in before you can comment on or make changes to this bug.