pages without title show 'null' as site name in Loop popup titlebar

RESOLVED FIXED

Status

Hello (Loop)
Client
P2
normal
Rank:
22
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aryx, Assigned: Sarthak Munshi, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(2 attachments)

Nightly 46.0a1 + Aurora 45.0a2 20160102, Windows 8.1

1. Open ftp://ftp.fau.de/ctan/graphics/mathspic/perl/README.txt
2. Start a Loop conversation.

Actual result:
Loop popup has 'null' as title.

Expected result:
Nothing in title bar or similar to conversation list 'Untitled Page'.
Mentor: standard8
Rank: 22
Priority: -- → P2
Whiteboard: [good first bug][lang=js]
(Assignee)

Comment 1

2 years ago
Hey Sebastian , can I be assigned to this bug ?
Assignee: nobody → sarthakmunshi
Status: NEW → ASSIGNED
Sarthak: Thank you for offering to take this bug.

Please note that we're now developing Hello primarily in a seperate repo - more details as https://github.com/mozilla/loop

There's code in mozilla-central, but we're stopping landing code directly there and we'll do exports from the github repo.
(Assignee)

Comment 3

2 years ago
Thanks for the information . I submit a patch on the github repo with the bug number in the title .
(Assignee)

Comment 4

2 years ago
* I will
Created attachment 8706937 [details] [review]
[loop] saru95:master > mozilla:master
Comment on attachment 8706937 [details] [review]
[loop] saru95:master > mozilla:master

I'll take a look tomorrow.
Attachment #8706937 - Flags: review?(standard8)
Comment on attachment 8706937 [details] [review]
[loop] saru95:master > mozilla:master

Hi Sarthak, thank you for the patch. I'm sorry I didn't get to it earlier.

I've commented on the PR with a couple of minor changes that I think it would make it even better.

If you could update the PR with those changes that'd be great. Once you've fixed those, please re-request review by selecting this attachment in bugzilla and setting the review flag to `?` and adding me in there.

I'm also going to file a bug on the fact that we're not getting the location for non-http/https pages. That seems to be a small issue that can be followed up at some stage. For now, I think its better to have a catch-all fallback, hence proceeding as we are.
Attachment #8706937 - Flags: review?(standard8)
(Assignee)

Updated

2 years ago
Flags: sec-review?(standard8)
Whoops, wrong flag, if you click the [details] button after the attachment name, the review flag is in there.

However, its looking good, we just need to squash the commits and change the title of them ready for landing.

Thank you.
Flags: sec-review?(standard8)
Created attachment 8708380 [details] [review]
[loop] saru95:master > mozilla:master
Landed as:

https://github.com/mozilla/loop/commit/f6755be5b8983c6862efc63403575fbc73f89991

Thanks you to Sarthak for your work on this.
Status: ASSIGNED → RESOLVED
Iteration: --- → 46.3 - Jan 25
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.