1236336 - pages without title show 'null' as site name in Loop popup titlebar

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nightly 46.0a1 + Aurora 45.0a2 20160102, Windows 8.1

1. Open ftp://ftp.fau.de/ctan/graphics/mathspic/perl/README.txt
2. Start a Loop conversation.

Actual result:
Loop popup has 'null' as title.

Expected result:
Nothing in title bar or similar to conversation list 'Untitled Page'.

Comment 1

[Sarthak Munshi]

Hey Sebastian , can I be assigned to this bug ?

Comment 2

[Mark Banner (:standard8)]

Sarthak: Thank you for offering to take this bug.

Please note that we're now developing Hello primarily in a seperate repo - more details as https://github.com/mozilla/loop

There's code in mozilla-central, but we're stopping landing code directly there and we'll do exports from the github repo.

Comment 3

[Sarthak Munshi]

Thanks for the information . I submit a patch on the github repo with the bug number in the title .

Comment 4

[Sarthak Munshi]

* I will

Comment 5

[GitHub Autolander Bot]

Attachment: [loop] saru95:master > mozilla:master

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8706937 [details] [review]
[loop] saru95:master > mozilla:master

I'll take a look tomorrow.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8706937 [details] [review]
[loop] saru95:master > mozilla:master

Hi Sarthak, thank you for the patch. I'm sorry I didn't get to it earlier.

I've commented on the PR with a couple of minor changes that I think it would make it even better.

If you could update the PR with those changes that'd be great. Once you've fixed those, please re-request review by selecting this attachment in bugzilla and setting the review flag to `?` and adding me in there.

I'm also going to file a bug on the fact that we're not getting the location for non-http/https pages. That seems to be a small issue that can be followed up at some stage. For now, I think its better to have a catch-all fallback, hence proceeding as we are.

Comment 8

[Mark Banner (:standard8)]

Whoops, wrong flag, if you click the [details] button after the attachment name, the review flag is in there.

However, its looking good, we just need to squash the commits and change the title of them ready for landing.

Thank you.

Comment 9

[GitHub Autolander Bot]

Attachment: [loop] saru95:master > mozilla:master

Comment 10

[Mark Banner (:standard8)]

Landed as:

https://github.com/mozilla/loop/commit/f6755be5b8983c6862efc63403575fbc73f89991

Thanks you to Sarthak for your work on this.