Closed
Bug 1236357
Opened 8 years ago
Closed 8 years ago
Disable GSFunctionSafeBuffersCheck check due to VS2015 false positive
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox46 affected, firefox47 fixed)
RESOLVED
FIXED
mozilla47
People
(Reporter: poiru, Assigned: poiru)
References
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
For VS2015 builds, the GSFunctionSafeBuffersCheck BinScope check warns about: long __cdecl __vcrt_trace_logging_provider::_TlgWrite(struct __vcrt_trace_logging_provider::_TlgProvider_t const *,void const *,struct _GUID const *,struct _GUID const *,unsigned int,struct _EVENT_DATA_DESCRIPTOR *): was declared __declspec(safebuffers) This is a false positive so lets just get rid of that check.
Attachment #8703435 -
Flags: review?(tabraldes)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8703435 [details] [diff] [review] disable-GSFunctionSafeBuffersCheck-check.patch This should be reviewed by a build system peer, not me. Ted - are you an appropriate reviewer for this?
Attachment #8703435 -
Flags: review?(tabraldes) → review?(ted)
|
Assignee | |
Comment 2•8 years ago
|
||
Review ping.
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8703435 [details] [diff] [review] disable-GSFunctionSafeBuffersCheck-check.patch Sending the r? to :gps to delegate as necessary
Attachment #8703435 -
Flags: review?(ted) → review?(gps)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8703435 -
Flags: review?(gps) → review?(ehsan)
|
||
Updated•8 years ago
|
Attachment #8703435 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04aa3c668d656aa1c1528eb074d78a98ecc88001 Bug 1236357 - Disable GSFunctionSafeBuffersCheck check due to false positive with VS2015. r=ehsan
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/04aa3c668d65
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•