Closed Bug 1236367 Opened 8 years ago Closed 8 years ago

Conform l20n.js to eslint rules

Categories

(Firefox OS Graveyard :: Gaia::L10n, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::L10n
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Details

Attachments

(1 file)

pull request
40 bytes, text/x-github-pull-request
stas
: review+
Details | Review 
      No description provided.
Attached file pull request — 
Ok, I think it's ready for review. I'll leave some comments in the PR to help you with review.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Attachment #8703501 - Flags: review?(stas)
Comment on attachment 8703501 [details] [review]
pull request

Great stuff, thanks for getting this done now before we start working on other patches.  r=me with a nit about XHR's 0 status which I think we still need for file:// URLs to work.
Attachment #8703501 - Flags: review?(stas) → review+
Commit: https://github.com/l20n/l20n.js/commit/bcf3950875223338c2862de881102f8038aea5dc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: