Closed
Bug 1236462
Opened 8 years ago
Closed 8 years ago
[CID 1242907] unused value ret
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(firefox46 affected)
RESOLVED
FIXED
3.22
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | affected |
People
(Reporter: franziskus, Assigned: franziskus)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID1242907)
Attachments
(1 file)
|
1.53 KB,
patch
|
mt
:
review+
mt
:
checked-in+
|
Details | Diff | Splinter Review |
There are unused return values in pcertdb.c:UpdateV6DB.
|
Assignee | |
Updated•8 years ago
|
Summary: [CID CID1242907] unused value ret → [CID 1242907] unused value ret
|
|
Assignee | |
Comment 1•8 years ago
|
||
returning SECFailure in case ret indicates an error. also at https://codereview.appspot.com/279690043
Attachment #8703550 -
Flags: review?(martin.thomson)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8703550 [details] [diff] [review] Bug1236462.patch Review of attachment 8703550 [details] [diff] [review]: ----------------------------------------------------------------- I have to assume that the call to (updatedb->close)(...) isn't a necessary piece of cleanup, since other places already return. https://hg.mozilla.org/projects/nss/rev/3a81f516a049
Attachment #8703550 -
Flags: review?(martin.thomson)
Attachment #8703550 -
Flags: review+
Attachment #8703550 -
Flags: checked-in+
|
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.22
You need to log in
before you can comment on or make changes to this bug.
Description
•