1236529 - Fix about:telemetry ping rendering & updating when changing views & reloading

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Georg Fritzsche [:gfritzsche]]

STR:
* go to about:telemetry
* choose "archived ping"
* choose "raw json" display
* reload

Expected:
Raw ping display.

Actual:
A "null" line, followed by the structured ping display.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Fix about:telemetry ping rendering

This fixes the ping rendering updating issues i see here, from reloading to flipping through views and archived pings. Would be happy to have a second look at it by you though. One thing im not so happy about is how PingPicker.update() looks now, but i dont think it can be improved too much without any bigger refactoring (and we need the change tracking there to not lose states all the time).

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8704573 [details] [diff] [review]
Fix about:telemetry ping rendering

Review of attachment 8704573 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. I agree with you, I'm not sure this could look much better without a refactoring.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a26f8e0d6463

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a26f8e0d6463