Closed Bug 1236546 Opened 4 years ago Closed 4 years ago

Don't deoptimize in ObjectGroup::defaultNewGroup when we have no proto

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Patch
1.10 KB, patch
bhackett
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
I think we can change this condition:

    if (!proto.isObject() || proto.toObject()->isNewGroupUnknown())
        initialFlags = OBJECT_FLAG_DYNAMIC_MASK;

to:

    if (proto.isLazy() || (proto.isObject() && proto.toObject()->isNewGroupUnknown()))
Attachment #8703633 - Flags: review?(bhackett1024)
Attachment #8703633 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/d1b7ec38dedc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Depends on: 1237998
You need to log in before you can comment on or make changes to this bug.