Closed
Bug 1236546
Opened 7 years ago
Closed 7 years ago
Don't deoptimize in ObjectGroup::defaultNewGroup when we have no proto
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
1.10 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
I think we can change this condition: if (!proto.isObject() || proto.toObject()->isNewGroupUnknown()) initialFlags = OBJECT_FLAG_DYNAMIC_MASK; to: if (proto.isLazy() || (proto.isObject() && proto.toObject()->isNewGroupUnknown()))
Attachment #8703633 -
Flags: review?(bhackett1024)
Updated•7 years ago
|
Attachment #8703633 -
Flags: review?(bhackett1024) → review+
Comment 2•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1b7ec38dedc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•