1236550 - Pinning to user environment during initial puppetization

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Rail Aliiev [:rail]]

AFAIK there is no easy way to use user environments during first puppetization, esp for aws_create_instance.py.

It'd be great to be able to pass --environment blah to puppetize.sh

Comment 1

[Rail Aliiev [:rail]]

Attachment: puppetize_pinned-puppet.diff

Something like this. cloud-tools PR incoming

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8703636 [details] [diff] [review]
puppetize_pinned-puppet.diff

Review of attachment 8703636 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/puppet/files/puppetize.sh
@@ +175,5 @@
>      # check for 'err:' in the output; this catches errors even
>      # when the puppet exit status is incorrect.
>      tmp=`mktemp /tmp/puppet-outputXXXXXX`
>      [ -f "$tmp" ] || hang "mktemp failed"
> +    /usr/bin/puppet agent $PUPPET_OPTIONS $PUPPET_EXTRA_OPTIONS> $tmp 2>1

nit space after "_EXTRA_OPTIONS"

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8703636 [details] [diff] [review]
puppetize_pinned-puppet.diff

remote:   https://hg.mozilla.org/build/puppet/rev/8bf88fc070ce
remote:   https://hg.mozilla.org/build/puppet/rev/af48e0c8d654

Comment 4

[Rail Aliiev [:rail]]

Attachment: cloud tools

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8704237 [details] [review]
cloud tools

r+ed in the PR.

Comment 6

[Rail Aliiev [:rail]]

https://wiki.mozilla.org/index.php?title=ReleaseEngineering%2FHow_To%2FLoan_a_Slave&diff=1111586&oldid=1103232