Closed
Bug 1236561
Opened 8 years ago
Closed 8 years ago
use UniquePtr<T[]> instead of nsAutoArrayPtr in dom/bluetooth/, easy cases
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Firefox OS Graveyard
Bluetooth
Tracking
(firefox46 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(3 files, 1 obsolete file)
|
3.08 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
1.24 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
12.95 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8703656 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•8 years ago
|
||
We don't need to copy data in this case, and making this change enables us to remove this use of nsAutoArrayPtr.
Attachment #8703657 -
Flags: review?(btian)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8703659 -
Flags: review?(btian)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8703657 [details] [diff] [review] part 2 - remove ObexHeaderSet::GetAuthChallenge Review of attachment 8703657 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8703657 -
Flags: review?(btian) → review+
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8703659 [details] [diff] [review] part 3 - make BluetoothConfigurationParameter.mValue a UniquePtr Review of attachment 8703659 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8703659 -
Flags: review?(btian) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8703656 [details] [diff] [review] part 1 - convert easy cases of nsAutoArrayPtr<T> to UniquePtr<T[]> in dom/bluetooth/ Review of attachment 8703656 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8703656 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Fix a SendSocketData mismatch for bluez code. Carrying over r+.
Attachment #8706534 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8703656 -
Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eae4260b2ff https://hg.mozilla.org/integration/mozilla-inbound/rev/7c415aa84205 https://hg.mozilla.org/integration/mozilla-inbound/rev/00c13feca0b7
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7eae4260b2ff https://hg.mozilla.org/mozilla-central/rev/7c415aa84205 https://hg.mozilla.org/mozilla-central/rev/00c13feca0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•