"Select your Add-ons" dialog shows Hello and Pocket

VERIFIED FIXED

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: rhelmer, Unassigned)

Tracking

unspecified
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox45+ verified, firefox46+ verified, firefox47 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Over the weekend I noticed that on my personal laptop (Ubuntu running Nightly) the "Select Your Add-ons" dialog shows both Hello and Pocket. They both indicate that they are installed by "You".
(Reporter)

Comment 1

2 years ago
(In reply to Robert Helmer [:rhelmer] from comment #0)
> Over the weekend I noticed that on my personal laptop (Ubuntu running
> Nightly) the "Select Your Add-ons" dialog shows both Hello and Pocket. They
> both indicate that they are installed by "You".

Do you know how to trigger this dialog, for QA purposes? If we have a test for this dialog it should be pretty easy to test for this and make sure these are hidden there I'd guess, but I am not sure how to make this come up through normal browsing (pretty sure I was using an older profile when I triggered this initially).
Flags: needinfo?(dtownsend)
(In reply to Robert Helmer [:rhelmer] from comment #1)
> (In reply to Robert Helmer [:rhelmer] from comment #0)
> > Over the weekend I noticed that on my personal laptop (Ubuntu running
> > Nightly) the "Select Your Add-ons" dialog shows both Hello and Pocket. They
> > both indicate that they are installed by "You".
> 
> Do you know how to trigger this dialog, for QA purposes? If we have a test
> for this dialog it should be pretty easy to test for this and make sure
> these are hidden there I'd guess, but I am not sure how to make this come up
> through normal browsing (pretty sure I was using an older profile when I
> triggered this initially).

When upgrading to a new Firefox (extensions.lastAppVersion is different) we check extensions.shownSelectionUI and if that isn't true we show the UI. You must have been upgrading from a very old profile, we implemented this some time ago. Happily we do have automated tests for this! See browser_select_* here https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser
Flags: needinfo?(dtownsend)
We have deleted this UI
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
[Tracking Requested - why for this release]:

Since we're not taking bug 1244302 in beta we should have this on release driver's radar. We could potentially do a smaller patch to hide these add-ons though even that would likely be harder than what bug 1244302 does.
status-firefox45: --- → affected
status-firefox46: --- → affected
status-firefox47: --- → fixed
tracking-firefox45: --- → ?
tracking-firefox46: --- → ?
Depends on: 1244302
Tracking as it is confusing.
Dave, are you going to implement the change? Thanks
tracking-firefox45: ? → +
tracking-firefox46: ? → +
Flags: needinfo?(dtownsend)
Created attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

Review commit: https://reviewboard.mozilla.org/r/35155/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35155/
Attachment #8719874 - Flags: review?(rhelmer)
Flags: needinfo?(dtownsend)
(Reporter)

Comment 7

2 years ago
Comment on attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

https://reviewboard.mozilla.org/r/35155/#review31725

::: toolkit/mozapps/extensions/content/selectAddons.js:79
(Diff revision 1)
> +        if (aAddon.type == "plugin" || aAddon.type == "service") {

I prefer always using braces so fine w/ me, but just wondering why this change in this patch?
Attachment #8719874 - Flags: review?(rhelmer) → review+
Did this land on m-c ?
If so we should uplift it to aurora and beta.
Flags: needinfo?(wkocher)
Flags: needinfo?(dtownsend)
Comment on attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Did this land on m-c ?
> If so we should uplift it to aurora and beta.

Sorry this slipped off my radar. This can't land on m-c or aurora since this problem was already fixed there by bug 1244302. This is a beta only patch.

Approval Request Comment
[Feature/regressing bug #]: System add-ons
[User impact if declined]: Users may accidentally disable system add-ons
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low risk just hides certain add-ons from the UI
[String/UUID change made/needed]: None
Flags: needinfo?(dtownsend)
Attachment #8719874 - Flags: approval-mozilla-beta?
Sylvestre maybe this can make it in time for beta 10? Looks like we do need it in 45
Flags: needinfo?(sledru)
Comment on attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

OK, approved. Too bad this is coming that late in the cycle :(
might be in 45 beta 10
Flags: needinfo?(sledru)
Attachment #8719874 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/3eaf4e1122e7
status-firefox45: affected → fixed
status-firefox46: affected → fixed
Assigning this to Bogdan, in terms of QA, since it might impact the Hello user experience.
Flags: qe-verify+
QA Contact: bogdan.maris
Reproduced the issue on Nightly 2016-01-05, Win 7, by setting "extensions.lastAppVersion" to a lower version and "extensions.shownSelectionUI"=FALSE and then restarting Firefox.
On Fx 45b10, "Select your Add-ons" dialog no longer shows Hello and Pocket.
On Fx 46.0a2 (2016-02-24) and 47.0a1 (2016-02-24) the selection UI is completely gone.
Status: RESOLVED → VERIFIED
status-firefox45: fixed → verified
status-firefox46: fixed → verified
status-firefox47: fixed → verified

Updated

2 years ago
Flags: needinfo?(wkocher)
Should the selection UI be gone completely as described in comment 14?
Flags: needinfo?(dtownsend)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #15)
> Should the selection UI be gone completely as described in comment 14?

Yes (bug 1244302)
Flags: needinfo?(dtownsend)
You need to log in before you can comment on or make changes to this bug.