1236717 - Run IPDL C++ unit tests by default or remove them

Status: RESOLVED FIXED

(Core :: IPC, defect, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Currently we're not building or running IPDL unit tests by default, mainly because they're linked into libxul (they use non-exported symbols) and not useful in a normal build.

Bug 1236635 comment #3 suggests they could be enabled in debug builds; making those slightly larger isn't a problem.

Also, we already have libxul-gtest for similar reasons — it's not linked until gtests are run (which we do, on automation) because the link step is slow and memory-intensive, but the gtests are compiled by default in the normal build.  We probably wouldn't want two of those, but maybe making the IPDL tests part of the gtests would be feasible.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

It seems to me IPDL tests fails on Windows... And I guess it fails everywhere else, too...

Comment 2

[(not currently active) Ted Mielczarek]

I think we should make a decision here: either we figure out how to run these in automation or we remove them. Having tests in the tree that don't get run doesn't add much value. They also are probably broken, as bugs like bug 1319914 and bug 1319912 show.

Comment 3

[(not currently active) Ted Mielczarek]

At some point we're hoping to move away from the make backend, so this stuff either needs to get moved to moz.build or it will go away:
https://hg.mozilla.org/mozilla-central/file/371e44e0034771ec8a5ac3c5a6518ef608227b99/ipc/ipdl/test/cxx/Makefile.in

Comment 4

[Alex Franchuk [:afranchuk]]

Now that bug 1751995 is landed, we can remove the cxx test directory.

Comment 5

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1236717 - Remove unused/unmigrated IPDL tests r=#ipc-reviewers

The tests we want to keep have been migrated to gtests and are run by
default.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbe9914bc4cd
Remove unused/unmigrated IPDL tests r=ipc-reviewers,nika

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bbe9914bc4cd