1236725 - Commits rewritten for autoland include users who did not give a ship-it

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Steven MacLeod [:smacleod]]

Currently our commit rewriting will include users who did not give a ship-it and users who gave a ship-it in the past but overrode it with a non ship-it review.

We should only include users who their most recent review has a ship-it. While we're at it we should also filter out the author as well (Although, it might be nice to throw in r=me if the author is the only user to have given a ship-it).

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: mozreview: only include ship-it reviews in rewritten commit messages (Bug 1236725). r?dminor

Currently our commit rewriting will include users who did not give a
ship-it and users who gave a ship-it in the past but overrode it with a
non ship-it review. This does not match up with how the approval hook
functions and also adds reviewers who did not sign off on the code.

We should only include users who their most recent review has a ship-it.
While we're at it we should filter out the author as well. In the event
that the author is the only user to have given a ship-it, we will now
include an r=me to show they approved their own commit.

Review commit: https://reviewboard.mozilla.org/r/29501/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29501/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8703893 [details]
MozReview Request: mozreview: only include ship-it reviews in rewritten commit messages (Bug 1236725). r?dminor

https://reviewboard.mozilla.org/r/29501/#review26333

lgtm

Comment 3

[Steven MacLeod [:smacleod]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/f1e1b526e19d