1236794 - apps/ringtones/test/marionette/pick_test.js | Ringtone picker tests are permared

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=19265039&repo=mozilla-inbound

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1236794-ringtones > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8728464 [details] [review]
[gaia] albertopq:1236794-ringtones > mozilla-b2g:master

Lets disable them for now

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8728464 [details] [review]
[gaia] albertopq:1236794-ringtones > mozilla-b2g:master

Please disable the failing test and not the entire file.

Comment 4

[Alberto Pastor [:albertopq]]

What do you mean? All 5 tests in that file are failing [1]. I think the issue is that mozTelephony is not available [2], so everything related to the ringtones button fails. Feel free to land the patch or propose a workaround. Thanks!

[1] https://public-artifacts.taskcluster.net/G4HnCXtHRxaykN6YZKatdQ/2/public/logs/live_backing.log
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/sound/tone_manager.js#L52

Comment 5

[Jim Porter (:squib)]

No, they're not all failing. As you can see in the log, many of them are passing, e.g.:

> TEST-START | apps/ringtones/test/marionette/pick_test.js | Ringtone picker Alert tones picker Load list of sounds
> Waiting for element  soundMenuItem
> Waiting for element  menuItemsSection
> Waiting for element  alerttoneButton
> TEST-PASS | apps/ringtones/test/marionette/pick_test.js | Ringtone picker Alert tones picker Load list of sounds
> TEST-END | apps/ringtones/test/marionette/pick_test.js | Ringtone picker Alert tones picker Load list of sounds took 10077 ms

It appears that the alert tones tests are passing, but the ringtones ones are failing, probably because something broke with the mozTelephony mock that we load here: <https://github.com/mozilla-b2g/gaia/blob/master/apps/ringtones/test/marionette/pick_test.js#L44>. The correct solution would be to fix that (or to find what broke it and back it out). While I know we're winding down support for Firefox OS, I hope that we can leave it in a working state with good (or at least decent) test coverage for when the community picks it up; disabling tests en masse just makes things worse for them.

Incidentally, what you're describing is a different bug from the one reported in comment 0 (which only affected the "Load list of sounds" test), so it probably would have been better to file a new bug.

Comment 6

[BMO Automation]

Firefox OS is not being worked on