Closed Bug 1236818 Opened 8 years ago Closed 8 years ago

Replace close_browser dialogs with window.confirm

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yifan, Assigned: yifan)

References

Details

Attachments

(1 file)

[gaia] begeeben:1236818_replace_confirm_dialogs > mozilla-b2g:master
46 bytes, text/x-github-pull-request
danhuang
: review+
rexboy
: review+
Details | Review 
      No description provided.
Assignee: nobody → yliao
Blocks: 1217731
No longer depends on: 1217731
Comment on attachment 8707359 [details] [review]
[gaia] begeeben:1236818_replace_confirm_dialogs > mozilla-b2g:master

Changed the browser app close_browser to window.confirm.

Rex could you please help to review the smart-system part? Thanks.
Attachment #8707359 - Flags: review?(rexboy)
Attachment #8707359 - Flags: review?(dhuang)
Status: NEW → ASSIGNED
Comment on attachment 8707359 [details] [review]
[gaia] begeeben:1236818_replace_confirm_dialogs > mozilla-b2g:master

Look good to me. Thanks for the effort!
Attachment #8707359 - Flags: review?(dhuang) → review+
Comment on attachment 8707359 [details] [review]
[gaia] begeeben:1236818_replace_confirm_dialogs > mozilla-b2g:master

Looks good to me. Thanks!
Attachment #8707359 - Flags: review?(rexboy) → review+
Blocks: 1240421
Blocks: 1240422
Summary: Replace confirm dialogs with window.confirm → Replace close_browser dialogs with window.confirm
Blocks: 1240446
Blocks: 1240448
https://github.com/mozilla-b2g/gaia/commit/7b62d937883214ef5b2b9109c6cae095f2c51da2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: