1237027 - JS error in RemoteAddonsParent.jsm: `invalid 'in' operand handler`

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Benjamin Smedberg]

Normal usage, every time I switch tabs with e10s enabled, I experience the following exception in the browser console:

invalid 'in' operand handler

This is at http://hg.mozilla.org/mozilla-central/annotate/29258f59e545/toolkit/components/addoncompat/RemoteAddonsParent.jsm#l561 and `handler` is undefined.

Bill, please let me know if there's other debugging I can do for this.

My environment:
  "environment": {
    "build": {
      "applicationId": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}",
      "applicationName": "Firefox",
      "architecture": "x86-64",
      "buildId": "20160105030211",
      "version": "46.0a1",
      "vendor": "Mozilla",
      "platformVersion": "46.0a1",
      "xpcomAbi": "x86_64-msvc",
      "hotfixVersion": "20150311.01"
    },
    "partner": {
      "distributionId": null,
      "distributionVersion": null,
      "partnerId": null,
      "distributor": null,
      "distributorChannel": null,
      "partnerNames": []
    },
    "system": {
      "memoryMB": 24520,
      "virtualMaxMB": 8388608,
      "cpu": {
        "count": 8,
        "cores": 8,
        "vendor": "GenuineIntel",
        "family": 6,
        "model": 62,
        "stepping": 4,
        "l2cacheKB": 256,
        "l3cacheKB": 10240,
        "speedMHz": 2494,
        "extensions": [
          "hasMMX",
          "hasSSE",
          "hasSSE2",
          "hasSSE3",
          "hasSSSE3",
          "hasSSE4_1",
          "hasSSE4_2"
        ]
      },
      "os": {
        "name": "Windows_NT",
        "version": "6.1",
        "locale": "en-US",
        "servicePackMajor": 1,
        "servicePackMinor": 0,
        "installYear": 2014
      },
      "hdd": {
        "profile": {
          "model": "ATA Micron_M550_2.5\"",
          "revision": "DL03"
        },
        "binary": {
          "model": "ATA Micron_M550_2.5\"",
          "revision": "DL03"
        },
        "system": {
          "model": "ATA Micron_M550_2.5\"",
          "revision": "DL03"
        }
      },
      "gfx": {
        "D2DEnabled": true,
        "DWriteEnabled": true,
        "adapters": [
          {
            "description": "AMD FirePro W5000 (FireGL V) Graphics Adapter",
            "vendorID": "0x1002",
            "deviceID": "0x6809",
            "subsysID": "0b061028",
            "RAM": 2048,
            "driver": "aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64",
            "driverVersion": "13.251.1.0",
            "driverDate": "12-23-2013",
            "GPUActive": true
          }
        ],
        "monitors": [
          {
            "screenWidth": 1200,
            "screenHeight": 1920,
            "refreshRate": 60,
            "pseudoDisplay": false
          },
          {
            "screenWidth": 3840,
            "screenHeight": 2160,
            "refreshRate": 60,
            "pseudoDisplay": false
          }
        ],
        "features": {
          "compositor": "d3d11",
          "d3d11": {
            "status": "available",
            "version": 45056,
            "warp": false,
            "textureSharing": true,
            "blacklisted": false
          },
          "d2d": {
            "status": "available",
            "version": "1.1"
          }
        }
      },
      "isWow64": false
    },
    "settings": {
      "blocklistEnabled": true,
      "e10sEnabled": true,
      "telemetryEnabled": true,
      "isInOptoutSample": false,
      "locale": "en-US",
      "update": {
        "channel": "nightly",
        "enabled": true,
        "autoDownload": true
      },
      "userPrefs": {
        "browser.cache.disk.capacity": 358400,
        "browser.newtabpage.enhanced": false,
        "browser.polaris.enabled": true,
        "browser.startup.page": 3,
        "browser.urlbar.userMadeSearchSuggestionsChoice": true,
        "devtools.chrome.enabled": true,
        "devtools.debugger.remote-enabled": true,
        "layout.css.devPixelsPerPx": "1.0",
        "privacy.donottrackheader.enabled": true
      },
      "addonCompatibilityCheckEnabled": true,
      "isDefaultBrowser": true,
      "defaultSearchEngine": "yahoo",
      "defaultSearchEngineData": {
        "name": "Yahoo",
        "loadPath": "jar:[app]/omni.ja!browser/yahoo.xml",
        "submissionURL": "https://search.yahoo.com/yhs/search?p=&ei=UTF-8&hspart=mozilla&hsimp=yhs-001"
      }
    },
    "profile": {
      "creationDate": 16232
    },
    "addons": {
      "activeAddons": {
        "[e-mail]": {
          "blocklisted": false,
          "description": "Sometimes you change a central password that ends up changing 12 others.  This add on helps you rese",
          "name": "Mass Password Reset",
          "userDisabled": false,
          "appDisabled": false,
          "version": "1.05.1-signed",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16351,
          "updateDay": 16558,
          "signedState": 2
        },
        "[e-mail]": {
          "blocklisted": false,
          "description": "Make your Firefox menu icon colorful instead of three boring lines.",
          "name": "Iconic Firefox Menu",
          "userDisabled": false,
          "appDisabled": false,
          "version": "2.0.1-signed",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16240,
          "updateDay": 16584,
          "signedState": 2
        },
        "jid0-1VwU0d7h7azvou6XbFWe9tmQyoQ@jetpack": {
          "blocklisted": false,
          "description": "Disables styles. Can be turned off via right-click menu.",
          "name": "Disable CSS",
          "userDisabled": false,
          "appDisabled": false,
          "version": "1.0.rev16.1-signed",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16462,
          "updateDay": 16584,
          "signedState": 1
        },
        "{91aa5abe-9de4-4347-b7b5-322c38dd9271}": {
          "blocklisted": false,
          "description": "Save frequently-entered text for pasting later.",
          "name": "Clippings",
          "userDisabled": false,
          "appDisabled": false,
          "version": "4.1.2.1-signed",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16679,
          "updateDay": 16679,
          "signedState": 2
        },
        "{c4080853-c699-4120-b8e0-618bff8a4474}": {
          "blocklisted": false,
          "description": "Select some text, right-click and choose \"IMDB Search\" in the menu, a new tab will open with the sea",
          "name": "IMDB  Search",
          "userDisabled": false,
          "appDisabled": false,
          "version": "1.0.1-signed",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16710,
          "updateDay": 16710,
          "signedState": 2
        },
        "TabsTree@traxium": {
          "blocklisted": false,
          "description": "Tabs how they must be.",
          "name": "Tab Tree",
          "userDisabled": false,
          "appDisabled": false,
          "version": "1.4.2",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16791,
          "updateDay": 16804,
          "signedState": 2
        },
        "[e-mail]": {
          "blocklisted": false,
          "description": "Web sharing for Firefox",
          "name": "Firefox Hello",
          "userDisabled": false,
          "appDisabled": false,
          "version": "0.1",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16770,
          "updateDay": 16804
        },
        "[e-mail]": {
          "blocklisted": false,
          "description": "When you find something you want to view later, put it in Pocket.",
          "name": "Pocket",
          "userDisabled": false,
          "appDisabled": false,
          "version": "46.0a1",
          "scope": 1,
          "type": "extension",
          "foreignInstall": false,
          "hasBinaryComponents": false,
          "installDay": 16804,
          "updateDay": 16804
        }
      },
      "theme": {
        "id": "{972ce4c6-7e08-4474-a285-3208198ce6fd}",
        "blocklisted": false,
        "description": "The default theme.",
        "name": "Default",
        "userDisabled": false,
        "appDisabled": false,
        "version": "46.0a1",
        "scope": 4,
        "foreignInstall": false,
        "hasBinaryComponents": false,
        "installDay": 16232,
        "updateDay": 16804
      },
      "activePlugins": [
        {
          "name": "Silverlight Plug-In",
          "version": "5.1.40728.0",
          "description": "5.1.40728.0",
          "blocklisted": false,
          "disabled": false,
          "clicktoplay": true,
          "mimeTypes": [
            "application/x-silverlight",
            "application/x-silverlight-2"
          ],
          "updateDay": 16644
        },
        {
          "name": "Shockwave Flash",
          "version": "20.0.0.267",
          "description": "Shockwave Flash 20.0 r0",
          "blocklisted": false,
          "disabled": false,
          "clicktoplay": true,
          "mimeTypes": [
            "application/x-shockwave-flash",
            "application/futuresplash"
          ],
          "updateDay": 16797
        }
      ],
      "activeGMPlugins": {
        "gmp-gmpopenh264": {
          "version": "1.5.3",
          "userDisabled": false,
          "applyBackgroundUpdates": 1
        },
        "gmp-eme-adobe": {
          "version": null,
          "userDisabled": false,
          "applyBackgroundUpdates": 1
        }
      },
      "activeExperiment": {},
      "persona": null
    }
  }

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Sorry for the delay here. That suggests that an add-on is passing something weird as the listener parameter to addEventListener. Can you try adding a dump statement somewhere in here:
http://hg.mozilla.org/mozilla-central/annotate/29258f59e545/toolkit/components/addoncompat/RemoteAddonsParent.jsm#l445

It would print |addon| and |listener|. If you see a |listener| value that's not a function or object, it would be interesting to know the add-on as well as maybe a stack trace so we can see what it's doing.

It's also possible there's a bug somewhere in this code and I'm not seeing it.

Comment 2

[Andy McKay]

Was this caused by a particular add-on, if so which one?

Comment 3

[Benjamin Smedberg]

Attachment: my activeAddons block

Here's my addons. I don't know which one.

Comment 4

[Shane Caraveo (:mixedpuppy)]

referenced code no longer exists