1237067 - Reset Intl.DateTimeFormatter when language changes

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

That's a regression from bug 1170973. I don't reset the formatter when language changes.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1237067-reset-formatter-in-gallery > mozilla-b2g:master

Comment 2

[Punam Dahiya [:pdahiya]]

(In reply to Autolander from comment #1)
> Created attachment 8704334 [details] [review]
> [gaia] zbraniecki:1237067-reset-formatter-in-gallery > mozilla-b2g:master

Zibi that was fast! this patch is perfect for 2.5, but it has merge conflict on master because of just landed l20n changes :)

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

sorry for that! Fixed :)

Comment 4

[Punam Dahiya [:pdahiya]]

Thanks Zibi, attached patch fixes group header on locale change. We are using formatter for thumbnail item desc for accessibility and similar reset is needed for ThumbnailItem.formatter.

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/thumbnail_item.js#L39

I believe using IntlHelper is another approach to fix this issue, however that might make the patch bigger and difficult to uplift.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Added!

Comment 6

[Punam Dahiya [:pdahiya]]

Comment on attachment 8704334 [details] [review]
[gaia] zbraniecki:1237067-reset-formatter-in-gallery > mozilla-b2g:master

LGTM! We do need a 2.5 patch and request for the uplift. Thanks Zibi for the fix!

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1237067-reset-formatter-in-gallery-2.5 > mozilla-b2g:v2.5

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8704782 [details] [review]
[gaia] zbraniecki:1237067-reset-formatter-in-gallery-2.5 > mozilla-b2g:v2.5

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1170973
[User impact] if declined: language change will not update date/time headers in Gallery
[Testing completed]: device
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 9

[Josh Cheng [:josh]]

Comment on attachment 8704782 [details] [review]
[gaia] zbraniecki:1237067-reset-formatter-in-gallery-2.5 > mozilla-b2g:v2.5

No needed for TV 2.5

Comment 10

[BMO Automation]

Firefox OS is not being worked on