Closed Bug 1237086 Opened 4 years ago Closed 4 years ago

displayport getter skips all tiling/texture size code for the root element of xul docs

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

XUL docs don't have a root scroll frame, so the particular way we got the frame from the content node meant we early returned for them.

Not sure this is important, but we should probably be consistent and not early return for this case as if it is unusual or an error.
Attached patch patchSplinter Review
Attachment #8704356 - Flags: review?(botond)
Comment on attachment 8704356 [details] [diff] [review]
patch

Review of attachment 8704356 [details] [diff] [review]:
-----------------------------------------------------------------

I just realized the bug 1194851 patches depend on this and so I should have reviewed this first. Anyways, this looks fine.
Attachment #8704356 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/d0a231612fd0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.