Closed Bug 1237105 Opened 6 years ago Closed 6 years ago

test-user-apis.t test failure due to ReviewBoard 2.5 upgrade

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

--- /Users/gps/src/hgcustom/version-control-tools/hgext/reviewboard/tests/test-user-apis.t
+++ /Users/gps/src/hgcustom/version-control-tools/hgext/reviewboard/tests/test-user-apis.t.err
@@ -19,8 +19,9 @@
 Unauthenticated users should not be able to search

   $ BUGZILLA_USERNAME= BUGZILLA_PASSWORD= rbmanage get-users joe
-  API Error: 500: 226: Bugzilla error: There is no Bugzilla API key on record for this user. Please log into MozReview's UI to have one generated.
-  [1]
+  - id: 4
+    url: /users/joe1%2B6/
+    username: joe1+6

   $ exportbzauth joe1@example.com password
ReviewBoard 2.5 swallows exceptions in auth backends. This is a change
in behavior from 2.0. smacleod says the old behavior may get restored
for a future release of 2.5. For now, update the test output so tests
pass.

Review commit: https://reviewboard.mozilla.org/r/29651/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29651/
Attachment #8704381 - Flags: review?(smacleod)
Comment on attachment 8704381 [details]
MozReview Request: mozreview: unauthenticated users can search now (bug 1237105); r?smacleod

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29651/diff/1-2/
Comment on attachment 8704381 [details]
MozReview Request: mozreview: unauthenticated users can search now (bug 1237105); r?smacleod

https://reviewboard.mozilla.org/r/29651/#review26471

::: hgext/reviewboard/tests/test-user-apis.t:19
(Diff revision 2)
> -Unauthenticated users should not be able to search
> +Unauthenticated users can search
> +TODO this may change in future versions of ReviewBoard 2.5

Can you change this to say something like "Unauthenticated users can search, but they will not cause any syncing of information from bugzilla (only the local Review Board user data is used)"
Attachment #8704381 - Flags: review?(smacleod) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.