123713 - [HAVE FIX] Various Karma module changes

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, defect)

Description

[Hixie (not reading bugmail)]

Some Karma commands clash with the Infobot query? syntax.

Comment 1

[Hixie (not reading bugmail)]

At the same time, we should add a way to get someone's individual rank (as well
as their score), prevent things likes "----" getting counted, and make people
drop off the list if they hit 0 karma.

Comment 2

[Hixie (not reading bugmail)]

Attachment: Patch: does what the previous comment suggests

Comment 3

[timeless]

@@ -85,6 +85,9 @@
@@ -93,6 +96,9 @@

seem to imply that code reuse could be implemented.

+            'rank' => 'Find someone\'s karma level. Omit the victim name to 
get a complete listing (long). Syntax: rank victim',

[victim], it's optional, you said so yourself in the previous sentence.

Comment 4

[Hixie (not reading bugmail)]

Attachment: Patch version 1.1

Ok, I changed the help line a little.

The code reuse idea is good, but unfortunately it would be hard to massage the
code into using the same system for the global list as the personal list while
still having an easy way to change the global list from the vars command.
Believe me, I tried.

Comment 5

[Hixie (not reading bugmail)]

Attachment: Patch version 1.2

Improves the help line some more.

Comment 6

[Hixie (not reading bugmail)]

While I'm at it, the if statement on line 141 should be negated to read:

           if (not defined($karma)) {
               $self->say($event, "You have not given $who any karma.");
           } else {
               $self->say($event, "You have given $who $karma points of karma.");
           }

Comment 7

[Hixie (not reading bugmail)]

checked in (kerz gave me r=kerz on IRC)

Comment 8

[Tanner M. Young [:tmyoung]]

Verified Fixed.