Closed Bug 1237132 Opened 6 years ago Closed 6 years ago

Safebrowsing pref name changes were missed the b2gdroid product

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: dveditz, Assigned: francois)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1107372 +++

The b2gdroid default prefs still use the old safebrowsing and trackingprotection pref names for updateURL and getHashURL. Safebrowsing seems to be enabled but I'm guessing it doesn't work.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/b2gdroid/app/b2gdroid.js#611
Attached patch bug1237132.patchSplinter Review
Assignee: gpascutto → francois
Status: NEW → ASSIGNED
Attachment #8708594 - Flags: review?(gpascutto)
In terms of testing, I'm not how to test b2gdroid, but we should definitely test Safe Browsing and Application Reputation on Desktop and Android to ensure we didn't break anything.
QA Contact: mwobensmith
Attachment #8708594 - Flags: review?(gpascutto) → review+
https://hg.mozilla.org/mozilla-central/rev/03dee128e789
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
QA Contact: mwobensmith
You need to log in before you can comment on or make changes to this bug.