Closed Bug 1237139 Opened 8 years ago Closed 8 years ago

Set the aria-valuetext on value pickerS container, not option

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Details

Attachments

(1 file)

[gaia] zbraniecki:1237139-valuepicker-aria-valuetext > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
yzen
: feedback+
Details | Review
Assignee: nobody → gandalf
Comment on attachment 8704438 [details] [review]
[gaia] zbraniecki:1237139-valuepicker-aria-valuetext > mozilla-b2g:master

Does it look like it should? When new selection is being made we set the aria-valuetext on the container.
Attachment #8704438 - Flags: feedback?(yzenevich)
Comment on attachment 8704438 [details] [review]
[gaia] zbraniecki:1237139-valuepicker-aria-valuetext > mozilla-b2g:master

Works perfectly! Thanks!
Attachment #8704438 - Flags: feedback?(yzenevich) → feedback+
Comment on attachment 8704438 [details] [review]
[gaia] zbraniecki:1237139-valuepicker-aria-valuetext > mozilla-b2g:master

Cool! Tim, can you review this change?
Attachment #8704438 - Flags: review?(timdream)
Attachment #8704438 - Flags: review?(timdream) → review+
Commit: https://github.com/mozilla-b2g/gaia/commit/8c87b9821fd839fb12d51b2f9a669352debf0cc7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: