Closed
Bug 1237146
Opened 8 years ago
Closed 8 years ago
Enable test_bug511449.html
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file, 1 obsolete file)
1.34 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
This test uses onunload, which didn't work in e10s until recently. We can re-enable it.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8704448 -
Flags: review?(wmccloskey)
Attachment #8704448 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3af36cb6d5485657d6ba42369449cd26e7477b8 Bug 1237146 - Enable this now-passing test. r=billm
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a3af36cb6d54
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 4•8 years ago
|
||
This still fails on OSX w/ e10s enabled: https://treeherder.mozilla.org/logviewer.html#?job_id=17298250&repo=try
Blocks: e10s-tests-osx
Status: RESOLVED → REOPENED
status-firefox46:
fixed → ---
Flags: needinfo?(mrbkap)
Resolution: FIXED → ---
Target Milestone: mozilla46 → ---
Assignee | ||
Comment 6•8 years ago
|
||
I must have tried running this on Linux or something. It appears that the new window/tab never receives focus for some reason. If I manually focus the tab's content, the test runs and passes as expected. Neil, do you have any ideas of why that would be?
Flags: needinfo?(mrbkap) → needinfo?(enndeakin)
Comment 8•8 years ago
|
||
No. Affects 10.6 as well.
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(enndeakin)
Comment 9•8 years ago
|
||
One option is to clear the capture when a context menu is opened. This could also affect popups opened via left-click as well (<select> maybe?) and I don't want it to happen when a popup opens without clicking (password prompt), so I'm limiting this to context menus to avoid issues.
Flags: needinfo?(enndeakin)
Attachment #8728543 -
Flags: feedback?(mrbkap)
Comment 10•8 years ago
|
||
Comment on attachment 8728543 [details] [diff] [review] releasecapture-onpopupopen Bah, wrong bug. Sorry.
Attachment #8728543 -
Flags: feedback?(mrbkap)
Comment 12•8 years ago
|
||
(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #6) > I must have tried running this on Linux or something. > > It appears that the new window/tab never receives focus for some reason. If > I manually focus the tab's content, the test runs and passes as expected. > Neil, do you have any ideas of why that would be? It's because the waitForFocus specialpowers implementation doesn't deal well with the case where you focus some other content window. I landed a fix in bug 1254091. That looks like it stuck on fx-team, so hopefully will be on m-c and m-inbound later today, at which point I think you should be able to reland (but a trypush might be wise :-) ).
Flags: needinfo?(enndeakin)
Assignee | ||
Comment 13•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6157cba78b7b
Assignee | ||
Updated•8 years ago
|
Attachment #8728543 -
Attachment is obsolete: true
Comment 15•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9613753f5c1c
Keywords: checkin-needed
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9613753f5c1c
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•