Closed Bug 1237146 Opened 4 years ago Closed 4 years ago

Enable test_bug511449.html

Categories

(Core :: Document Navigation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file, 1 obsolete file)

This test uses onunload, which didn't work in e10s until recently. We can re-enable it.
Attached patch PatchSplinter Review
Attachment #8704448 - Flags: review?(wmccloskey)
Attachment #8704448 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/a3af36cb6d54
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
This still fails on OSX w/ e10s enabled:
https://treeherder.mozilla.org/logviewer.html#?job_id=17298250&repo=try
Status: RESOLVED → REOPENED
Flags: needinfo?(mrbkap)
Resolution: FIXED → ---
Target Milestone: mozilla46 → ---
I must have tried running this on Linux or something.

It appears that the new window/tab never receives focus for some reason. If I manually focus the tab's content, the test runs and passes as expected. Neil, do you have any ideas of why that would be?
Flags: needinfo?(mrbkap) → needinfo?(enndeakin)
Is this 10.10 specific?
Flags: needinfo?(enndeakin)
No. Affects 10.6 as well.
Flags: needinfo?(enndeakin)
Attached patch releasecapture-onpopupopen (obsolete) — Splinter Review
One option is to clear the capture when a context menu is opened. This could also affect popups opened via left-click as well (<select> maybe?) and I don't want it to happen when a popup opens without clicking (password prompt), so I'm limiting this to context menus to avoid issues.
Flags: needinfo?(enndeakin)
Attachment #8728543 - Flags: feedback?(mrbkap)
Comment on attachment 8728543 [details] [diff] [review]
releasecapture-onpopupopen

Bah, wrong bug. Sorry.
Attachment #8728543 - Flags: feedback?(mrbkap)
Neil, any other ideas about comment 6?
Flags: needinfo?(enndeakin)
See Also: → 1254091
(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #6)
> I must have tried running this on Linux or something.
> 
> It appears that the new window/tab never receives focus for some reason. If
> I manually focus the tab's content, the test runs and passes as expected.
> Neil, do you have any ideas of why that would be?

It's because the waitForFocus specialpowers implementation doesn't deal well with the case where you focus some other content window. I landed a fix in bug 1254091. That looks like it stuck on fx-team, so hopefully will be on m-c and m-inbound later today, at which point I think you should be able to reland (but a trypush might be wise :-) ).
Flags: needinfo?(enndeakin)
Attachment #8728543 - Attachment is obsolete: true
This passes now. Let's try it again.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9613753f5c1c
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.