1237174 - Remove some unnecessary code from MDSM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

After overhauling the thread model of MDSM, there are some code that can be removed  like [1]. There is no way for mState to change to something else in the case of DECODER_STATE_COMPLETED.

[1] https://hg.mozilla.org/mozilla-central/file/29258f59e5456a1a518ccce6b473b50c1173477e/dom/media/MediaDecoderStateMachine.cpp#l2364

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=398b1905ea1b

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1237174 - Remove the unnecessary code since mState won't change in the case of DECODER_STATE_COMPLETED.

Review commit: https://reviewboard.mozilla.org/r/29685/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29685/

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8704493 [details]
MozReview Request: Bug 1237174 - Remove the unnecessary code since mState won't change in the case of DECODER_STATE_COMPLETED.

https://reviewboard.mozilla.org/r/29685/#review26511

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ec5ef461de

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5ec5ef461de