[Simulator] fail to create TVSimulatorService

RESOLVED FIXED

Status

Firefox OS
Simulator
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: schien, Assigned: mantaroh)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

https://dxr.mozilla.org/mozilla-central/source/dom/tv/TVSimulatorService.js#20 will throw exception if preference doesn't exist.
This is a regression of bug 1200133.
(Assignee)

Comment 1

2 years ago
Hi schien.

Thank you for your investigation.
I should have considered exception when load the file.
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8704889 [details] [diff] [review]
Modify implementation of reading reference.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=177aa7c52289
(Assignee)

Comment 3

2 years ago
Comment on attachment 8704889 [details] [diff] [review]
Modify implementation of reading reference.

Hi sean.

I've forgot the check to exception when loading the |TVSimulatorService.js|.
So I fixed this code.

Could you confirm this?
Attachment #8704889 - Flags: review?(selin)
(Assignee)

Comment 4

2 years ago
Created attachment 8704999 [details] [diff] [review]
Modify implementation of reading reference.

Hi Sean,

I forgot the remove to unnecessary space.
Attachment #8704889 - Attachment is obsolete: true
Attachment #8704889 - Flags: review?(selin)
Attachment #8704999 - Flags: review?(selin)
Comment on attachment 8704999 [details] [diff] [review]
Modify implementation of reading reference.

Review of attachment 8704999 [details] [diff] [review]:
-----------------------------------------------------------------

r=me once the following comments are addressed.

::: dom/tv/TVSimulatorService.js
@@ +49,5 @@
>      if (this._internalTuners) {
>        return;
>      }
>  
> +    // We will determine testing environment.

nit: rephrase the comment and try to be more clear.

// Try to load the testing mock data if they are already set. Otherwise, fall back to load the simulation data.

@@ +59,4 @@
>          settingStr = this._getDummyData();
> +      } catch(e) {
> +        debug("Error occurred : " + e);
> +        debug("Line:" + e.lineNumber);

nit: the error message above could be more specific. For example,

debug("TV simulator service failed to load the simulation data: " + e);

@@ +64,2 @@
>        }
> +      debug("Can't read dom.testing.tv_mock_data");

nit: it appears no need for this message.
Attachment #8704999 - Flags: review?(selin) → review+
(Assignee)

Comment 6

2 years ago
Created attachment 8705456 [details] [diff] [review]
Modify implementation of loading reference.

Thanks Sean.

(In reply to Sean Lin [:seanlin] from comment #5)
> Comment on attachment 8704999 [details] [diff] [review]
> Modify implementation of reading reference.
> 
> Review of attachment 8704999 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me once the following comments are addressed.
I fixed the comment and wrong indent tab. 

Thanks.
Attachment #8704999 - Attachment is obsolete: true
Attachment #8705456 - Flags: review?(selin)
Attachment #8705456 - Flags: review?(selin) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Summary: fail to create TVSimulatorService → [Simulator] fail to create TVSimulatorService

Comment 7

2 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/7f9f66c6114e
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f9f66c6114e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.