1237221 - [TV] FxOS TV Metrics - The hard-coded marketplace origins need to be adjusted for TV

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Luke Chang [:lchang] (inactive)]

App Usage Metrics currently uses a hard-coded white list to determine which apps are installed by Marketplace and should be recorded [1].

We have two tasks in this bug.

1. To confirm whether the origin of TV marketplace is the same as phone's.

2. Due to the implementation of the preview mode, apps on TV may be installed by System app sometimes. Therefore, we need to add the origin of System app to the white list as well.


[1] https://github.com/luke-chang/gaia/blob/master/tv_apps/smart-system/js/app_usage_metrics.js#L104

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

The origin of TV would be 'https://marketplace.firefox.com/tv/'.
Not sure if the API keep detail path or just domain name.

But since it's just an array, seems all we need to do is just to attach origin of system app and may be the tv marketplace above.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1237221 > mozilla-b2g:master

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8707806 [details] [review]
[gaia] rexboy7:1237221 > mozilla-b2g:master

As a result, we only need to add system app to the list of install origin.

But since the marketplace website of TV is not online yet, we can only test it after it's completed. Basically it should be ok since the domain name will be the same for tv and phone, but I'm not really sure if the path "/tv/" would be included in install origin or not. We can test it after the site goes online.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Luke may you review this simple patch?

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8707806 [details] [review]
[gaia] rexboy7:1237221 > mozilla-b2g:master

Nice!

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/aa519231ffb8b39224496277a12fd5e3692fcb7f

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8707806 [details] [review]
[gaia] rexboy7:1237221 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature
[User impact] if declined: Can't log app usage installed from tv marketplace
[Testing completed]: local done
[Risk to taking this patch] (and alternatives if risky): small
[String changes made]: none

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8707806 [details] [review]
[gaia] rexboy7:1237221 > mozilla-b2g:master

Approve for TV 2.5

Comment 9

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/b7fd1e3309f3feecf03919e065a6f1ddf82e36b5

Comment 10

[Carsten Book [:Tomcat]]

should be https://github.com/mozilla-b2g/gaia/commit/d0de5693bea9952e89ed54d17d71ba6efad62e8b