Closed
Bug 1237237
Opened 8 years ago
Closed 8 years ago
Make the log parser more resilient against malformed step marker dates
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P1)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
To avoid things like bug 1236655 from breaking log parsing, we should handle malformed dates in the logs (in the step marker lines) and fall back to no duration rather than break the whole log parse (which results in no error summary).
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8704623 -
Flags: review?(cdawson)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8704624 [details] [review] [treeherder] mozilla:handle-bad-log-dates > mozilla:master (Duplicate attachment; have filed bug 1237261 against autolander)
Attachment #8704624 -
Attachment is obsolete: true
Comment 4•8 years ago
|
||
Comment on attachment 8704623 [details] [review] [treeherder] mozilla:handle-bad-log-dates > mozilla:master Looks awesome! Thanks for doing this!
Attachment #8704623 -
Flags: review?(cdawson) → review+
Comment 5•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/881e17cdfc4e29eeecd2e808fa63a3df35c7a8c7 Bug 1237237 - Log parser: Handle malformed step marker dates gracefully This avoids breaking the whole log parsing task (including error summary generation) if the dates are invalid (eg like in bug 1236655). Instead the UI will just display the duration as 'unknown'. https://github.com/mozilla/treeherder/commit/a6df6ff1c12e24a2f53efa23a75ddfa1ac4fd19a Bug 1237237 - Log parser: Refactor set_duration() To avoid repetition, the current step's duration is now set outside of the function that calculates the duration.
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•