1237244 - Travis ui-tests are failing due to the latest release of socket.io

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

The UI tests are failing:
https://travis-ci.org/mozilla/treeherder/jobs/100563155

More significantly, retriggers of previously green runs are now failing too:
https://travis-ci.org/mozilla/treeherder/jobs/100395719

tl;dr...
* we pin to karma v0.13.10 in our package.json, however it's sub-dependencies aren't pinned by us [1], only by what karma specifies (which is ^1.3.7, ie 1.*.*).
* however socket.io have made a breaking change in a minor rather than major version - and 12 hours ago released v1.4.0.

-> We can either manually pin to socket.io 1.3.7 or else update to the latest karma, which adds support for this breaking socket.io change.

See:
https://github.com/socketio/socket.io/issues/2368
https://github.com/karma-runner/karma/issues/1782

[1] We do use npm shrinkwrap, however due to limitations with it (particularly with older node/npm versions like is on stage/prod), only use it for dependencies not devDependencies. Hopefully in the future npm changes will be made that make it more practical for us to shrinkwrap the devDependencies too.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:fix-karma-socketio-errors > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/86b636650b0c87878a68452254dd890cd77defe3
Bug 1237244 - Update to karma v0.13.19 to support new socket.io API

socket.io released backwards incompatible API changes in a minor version
update, causing failures during our ui-tests travis run. See:
https://github.com/socketio/socket.io/issues/2368

However the latest version of Karma has added support for it:
https://github.com/karma-runner/karma/issues/1782