1237295 - TEST-UNEXPECTED-ERROR | test_places.py TestPlaces.test_plugins | NameError: global name 'errors' is not defined

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Something changed in Firefox Nightly which caused a hidden problem be raised:

 06:55:58     INFO - Traceback (most recent call last):
 06:55:58     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run
 06:55:58     INFO -     testMethod()
 06:55:58     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/tests/test_places.py", line 66, in test_bookmarks
 06:55:58     INFO -     self.places.restore_default_bookmarks()
 06:55:58     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/api/places.py", line 105, in restore_default_bookmarks
 06:55:58     INFO -     raise errors.MarionetteException("Restore Default Bookmarks failed")

The issue is here:

https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_puppeteer/api/places.py#L8
https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_puppeteer/api/places.py#L105

We import the error classes directly but when raising an exception we use the errors module as prefix.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Github PR

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Merged PR to mozilla-central branch as:
https://github.com/mozilla/firefox-ui-tests/commit/b4af4d8dcc84c9d5d43d44ff25671d040920cbb1

It's not a bustage on other branches yet, so I will backport this later today or tomorrow.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I also updated the python_packages branch for this change by rebasing it against mozilla-central.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Backports for other affected branches:

https://github.com/mozilla/firefox-ui-tests/commit/6570a995800dcbca56abc8be449614ab837355dd (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/58cf08105f8e10bca1d51a2ad3c69a929cdd32c8 (beta)
https://github.com/mozilla/firefox-ui-tests/commit/fe145ef9d823865efcd2610ac92325493ed6d645 (release)

Comment 5

[Intermittent Failures Robot]

37 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 37

Platform breakdown:
* windows8-64: 5
* windows7-64: 5
* windowsxp: 3
* windows8-32: 3
* windows7-32: 3
* osx-10-9: 3
* osx-10-6: 3
* osx-10-11: 3
* osx-10-10: 3
* linux64: 3
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237295&startday=2016-01-04&endday=2016-01-10&tree=all