1237329 - Various test failures in test_places.TestPlaces.* for restore_default_bookmarks() due to URI change for bookmarks.html

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is a new regression since yesterdays Nightly build. Travis fails for both Linux and OS X:

https://travis-ci.org/mozilla/firefox-ui-tests/jobs/100625382

 1:57.14 LOG: MainThread INFO test_places.py test_places.TestPlaces.test_history
 1:57.14 LOG: MainThread INFO test_places.py test_places.TestPlaces.test_bookmarks
 1:57.14 LOG: MainThread INFO test_places.py test_places.TestPlaces.test_bookmarks
 1:57.14 LOG: MainThread INFO test_places.py test_places.TestPlaces.test_history
 1:57.14 LOG: MainThread INFO test_places.py test_places.TestPlaces.test_plugins

No idea yet why this is broken. It works fine locally. So I have to do more investigation here.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Pushlog:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=29258f59e545&tochange=9d6ffc7a08b6

So this is actually a regression from the changes on bug 1235108.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The fix here will be the same as for the following changeset:

https://hg.mozilla.org/mozilla-central/diff/21e3cdc18595/browser/components/migration/MigrationUtils.jsm#l294

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Github PR

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Merged the PR to mozilla-central as:
https://github.com/mozilla/firefox-ui-tests/commit/2db45049892de26bd8a679b9b0f55d44366ef42d

I have also force pushed this change after a rebase to the python_packages branch.

Comment 5

[Intermittent Failures Robot]

13 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 13

Platform breakdown:
* windows8-64: 2
* windows7-64: 2
* windowsxp: 1
* windows8-32: 1
* windows7-32: 1
* osx-10-9: 1
* osx-10-6: 1
* osx-10-11: 1
* osx-10-10: 1
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237329&startday=2016-01-04&endday=2016-01-10&tree=all

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So this test failure was fixed in mozilla-central on January 6th via bug 1235107. Not sure why but the change to our test hasn't been made it into mozilla-aurora, while I can still see the change being landed on that branch:

http://hg.mozilla.org/releases/mozilla-aurora/rev/21e3cdc18595

vs.

http://mxr.mozilla.org/mozilla-aurora/source/testing/puppeteer/firefox/firefox_puppeteer/api/places.py#87


Rail, any idea what was going wrong with the merge here? Maybe there was a conflict which hasn't been properly solved?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I talked with Rail on IRC and we figured out the problem. I thought that production is already using test packages but that is currently not the case. So the failure happened because I merged the branches too late yesterday.

Comment 8

[Intermittent Failures Robot]

35 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 35

Platform breakdown:
* osx-10-9: 4
* osx-10-6: 4
* osx-10-11: 4
* osx-10-10: 4
* linux32: 4
* windows8-64: 3
* windows7-64: 3
* linux64: 3
* windowsxp: 2
* windows8-32: 2
* windows7-32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1237329&startday=2016-01-25&endday=2016-01-31&tree=all