Move markup view into the Inspector directory

RESOLVED FIXED in Firefox 46

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gl, Assigned: gl)

Tracking

unspecified
Firefox 46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Comment on attachment 8704731 [details] [diff] [review]
1237335.patch

Review of attachment 8704731 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
It'd be nice to rename all tests too, from browser_markupview_* to browser_markup_*, but let's do that in a later patch/bug, I don't want ask you to re-update this patch.
Could you send an email to the dev-developer-tools mailing list too, letting people know about this somewhat big file move (rule, computed, markup, font, layout).
Attachment #8704731 - Flags: review?(pbrosset) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8704981 [details] [diff] [review]
1237335.patch
Attachment #8704731 - Attachment is obsolete: true
Attachment #8704981 - Flags: review+

Comment 5

2 years ago
This has caused widespread bustages like this:

devtools/client/projecteditor/test/browser_projecteditor_tree_selection_02.js | Test timed out -
https://treeherder.mozilla.org/logviewer.html#?job_id=6481140&repo=fx-team

I will probably back it out if retriggers also come out orange.
Flags: needinfo?(gl)

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/a236b6aa15d68b434a8eacb2d21aa1f4a27f42f7
Backed out changeset 9c6a36040f06 (bug 1237335) for widespread devtools bustage
(Assignee)

Comment 7

2 years ago
Created attachment 8705282 [details] [diff] [review]
1237335.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c725eabc8c65
Attachment #8704981 - Attachment is obsolete: true
Flags: needinfo?(gl)
(Assignee)

Updated

2 years ago
Attachment #8705282 - Flags: review+

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/27819a473fee
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46

Comment 10

2 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.