1237339 - firefoxtrees extension chokes on try

Status: RESOLVED FIXED

(Developer Services :: Mercurial: firefoxtree, defect)

Description

[u408661]

Since I returned from holidays and updated my copy of v-c-t, I've noticed that doing an "hg pull fxtrees" or "hg fxheads" ends with an error, always related to the try repo:

~/s/m/gecko> hg pull fxtrees
pulling from central
searching for changes
no changes found
pulling from inbound
searching for changes
no changes found
pulling from try
searching for changes
abort: HTTP Error 413: Request Entity Too Large
~/s/m/gecko> hg fxheads
278413:0771c5eab32f central merge mozilla-inbound to mozilla-central a=merge
278509:ef0cfe8a2f77 inbound Bug 1236170 - Make Http2Session::UncompressAndDiscard push-aware. r=mcmanus
abort: unknown revision '650fead5d9660297f55dd541780e3d0cc1c1e4ee'!
~/s/m/gecko> cat .hg/firefoxtrees
central 0771c5eab32f0cee4f7d12bc382298a81e0eabb2
inbound ef0cfe8a2f77da20f703a8f514e74846dfddff9d
try 650fead5d9660297f55dd541780e3d0cc1c1e4ee

I can fix this (temporarily) by removing the "try" entry from .hg/firefoxtrees, but the next time I "hg push try", that line gets re-added, and the errors start again. I have a patch (that I'll shove in mozreview) that fixes/papers over the errors by ignoring try in the two cases above, though I suspect there are more things I'm missing (or perhaps I should just prevent try from getting written to .hg/firefoxtrees at all).

Comment 1

[u408661]

Attachment: MozReview Request: Bug 1237339 - Ignore try in cases where it doesn't make sense

Review commit: https://reviewboard.mozilla.org/r/29717/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29717/

Comment 2

[u408661]

I'm sure the commit message needs updating to follow v-c-t standards (as well as, quite possibly, the code, to not be stupid), but this was all done quickly to allow me to get my normal work done without errors shouting at me :)

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8704722 [details]
MozReview Request: Bug 1237339 - Ignore try in cases where it doesn't make sense

https://reviewboard.mozilla.org/r/29717/#review26559

I implemented a slightly different version as soon as I saw the bug report.

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: firefoxtree: don't track try repos (bug 1237339); r?dminor

It doesn't make sense to track remote refs for try repos. Filter try
repos from the repos list when reading and writing the file and when
updating remote refs.

Review commit: https://reviewboard.mozilla.org/r/29725/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29725/

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8704739 [details]
MozReview Request: firefoxtree: don't track try repos (bug 1237339); r?dminor

https://reviewboard.mozilla.org/r/29725/#review26561

lgtm

Comment 6

[Gregory Szorc [:gps]]

Autolanded.