Closed
Bug 1237343
Opened 8 years ago
Closed 8 years ago
Don't use mozilla::Vector in APZ code
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
mozilla::Vector is fallible, see bug 1237201. We don't want that in APZ code, so we should use std::vector or nsTArray or something.
Assignee | ||
Comment 1•8 years ago
|
||
We discussed at concluded that nsTArray is superior to std::vector, so we should do that.
Updated•8 years ago
|
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46723/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46723/
Attachment #8741733 -
Flags: review?(botond)
Assignee | ||
Comment 3•8 years ago
|
||
Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=de90bccb612d
Assignee: nobody → bugmail.mozilla
Comment 4•8 years ago
|
||
Comment on attachment 8741733 [details] MozReview Request: Bug 1237343 - Replace uses of mozilla::Vector with nsTArray. r?botond https://reviewboard.mozilla.org/r/46723/#review43457 Thanks! I never liked those MOZ_CRASH()es.
Attachment #8741733 -
Flags: review?(botond) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b9d0760ce84c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•