Closed
Bug 1237404
Opened 8 years ago
Closed 8 years ago
Optimization and exposing more functionality in gfxCrashReporterUtils
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: milan, Assigned: milan)
References
Details
(Keywords: feature, Whiteboard: [gfx-noted])
Attachments
(2 files, 2 obsolete files)
|
4.63 KB,
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
|
1005 bytes,
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
Inspired by changes in bug 1235437 and the first review comment in bug 1235437 comment 2. Avoid sending things to main thread if we're already on the main thread, and refactor things somewhat to expose underlying functionality for other use.
|
Assignee | |
Comment 1•8 years ago
|
||
Also, keep bug 737413 in mind.
Assignee: nobody → milan
Whiteboard: [gfx-noted]
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29755/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29755/
Attachment #8704815 -
Flags: review?(bgirard)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29757/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29757/
Attachment #8704816 -
Flags: review?(bgirard)
|
||
Updated•8 years ago
|
Attachment #8704815 -
Flags: review?(bgirard) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8704815 [details] MozReview Request: Bug 1237404: Part 1. Exposing some functionality in gfxCrashReporterUtils. r?benwa https://reviewboard.mozilla.org/r/29755/#review26597
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8704816 [details] MozReview Request: Bug 1237404: Part 2. Optimizing the main thread scenario. r?benwa https://reviewboard.mozilla.org/r/29757/#review26599
Attachment #8704816 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
Missing include.
Attachment #8704815 -
Attachment is obsolete: true
Attachment #8704816 -
Attachment is obsolete: true
Attachment #8705816 -
Flags: review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54517baccc9c to deal with build errors on some configurations from the run that also ran the tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1997155d86c&selectedJob=15212229
Attachment #8705818 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/20e88a76cb9c https://hg.mozilla.org/integration/mozilla-inbound/rev/bd4db6412237
Keywords: checkin-needed
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/20e88a76cb9c https://hg.mozilla.org/mozilla-central/rev/bd4db6412237
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•