1237426 - FF43 Partner repack changes for Yahoo - New builds needed with latest version of toolbar

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Sneha Datla]

Hi,

We made a recent change to the toolbar code to address the issue where toolbar's AMO signature was getting invalidated. Our PR for this was merged. Can we get new Yahoo custom builds with this change?

Thanks,
Sneha

Comment 1

[Mike Connor [:mconnor]]

43.0.4 builds are already available on the partner portal.  Do those not have the latest config updates?

Comment 2

[Shane Caraveo (:mixedpuppy)]

I merged the yahoo changes @ 2:24PST Jan 6, they probably made it into the new builds but it should be verified.

Sneha, let us know if the new builds are ok.

Comment 3

[Sneha Datla]

Yes the new 43.0.4 builds have the latest changes. However, the toolbar is disabled on the Mac builds but it is fine in the Windows builds. Any idea?

Comment 4

[Shane Caraveo (:mixedpuppy)]

Sneha, is it disabled or just hidden?  ie. can you make it appear via the View->Toolbars menu?  Was it visible in prior versions?

Comment 5

[Sneha Datla]

Attachment: Toolbar is disabled on Mac build

It's disabled and will show up only if xpinstall.signatures.required pref is set to false. It was fine in FF42 but not with FF43.

Windows builds are fine. The issue is only on the Mac builds

Comment 6

[Shane Caraveo (:mixedpuppy)]

I just downloaded the addon from AMO and diff'd against what is in github.  One file, components/nsYahooPluginManager.js, is different (might even be only line endings) which would cause a signing failure.  That failure should be happening on all platforms but am only testing on osx right now.  If you can fix this issue and create a new pull request, then we can request a respin.

Comment 7

[Shane Caraveo (:mixedpuppy)]

jorge, mconnor,

would line ending differences cause a signing failure on osx but not on windows?  If that is the case, seems like a bug in the signing check.

Comment 8

[Sneha Datla]

Yes there are ^M characters at the end of the lines in that file. I will remove the ^M characters in that file and I'll create a PR for that once it's fixed

Thanks!

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

If the file is being modified after it was signed, I wouldn't consider that a signature bug. We can't account for all possible line ending formats and/or file encodings.

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Jorge Villalobos [:jorgev] from comment #9)
> If the file is being modified after it was signed, I wouldn't consider that
> a signature bug. We can't account for all possible line ending formats
> and/or file encodings.

Jorge, the same file in the repack, signing passes on windows (I'm assuming Sneha tested correctly), fails on osx (I verified osx).  My question is more around, should that be happening, if so why?

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

It shouldn't be happening if the same files are just being moved/copied. It can be that the files are being modified somehow, or one of the folders containing those files was opened by the user using Finder/File Manager, which sometimes generates hidden files in those folders.

Comment 12

[Shane Caraveo (:mixedpuppy)]

@coop, could we respin yahoo 43.0.4?

Comment 13

[Chris Cooper [:coop] (he/him)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #12)
> @coop, could we respin yahoo 43.0.4?

Yep, I'll kick that off now.

Comment 14

[Sneha Datla]

The latest builds are working fine now.

Thanks!